add irrigation detection query #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaime-82
requested review from
christophertull,
dmarulli,
jin-current,
mdowell12 and
pat-current
as code owners
mdowell12
reviewed
Nov 3, 2025
Collaborator
mdowell12
left a comment
mdowell12
left a comment
There was a problem hiding this comment.
@jaime-82 looks like the linter is failing. You can fix that by running black . from the root of the repo with your virtualenv turned on. Let me know if you have trouble. I can fix it, but I'd prefer if you did it before merging.
Otherwise, left one question and the query LGTM.
| , district_source | ||
| , meter_type | ||
| from | ||
| irrigation_detection |
Collaborator
There was a problem hiding this comment.
@jaime-82 how is irrigation_detection created? Will this fail if someone hasn't manually created it already?
If so, could you add a create table statement somewhere in the sql folder so that people know how to create the table?
Collaborator
|
Hey @jaime-82 checking in on this - are you still hoping to merge the work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.