feat: configurable minimum deposit amount#86
Merged
greatest0fallt1me merged 7 commits intoCalloraOrg:mainfrom Feb 27, 2026
Merged
feat: configurable minimum deposit amount#86greatest0fallt1me merged 7 commits intoCalloraOrg:mainfrom
greatest0fallt1me merged 7 commits intoCalloraOrg:mainfrom
Conversation
- Add tests for minimum deposit enforcement (issue CalloraOrg#43) - deposit_below_minimum_panics: verifies deposits below min_deposit panic - deposit_equal_to_minimum_succeeds: verifies exact minimum is accepted - deposit_with_zero_minimum_always_succeeds: verifies min=0 disables restriction - Fix init_none_balance test to use correct init() signature
Contributor
|
@Jopsan-gm resolve the conflicts |
Contributor
Author
|
@greatest0fallt1me conflicts resolved! |
Contributor
|
@Jopsan-gm please resolve the conflicts |
Contributor
Contributor
Author
|
Hey @greatest0fallt1me sorry for the delay, the conflicts have been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #43
Adds tests to enforce the configurable minimum deposit amount in the vault contract.
Changes
min_depositpanics with"deposit below minimum"min_deposit = 0disables the restriction (any amount accepted)usdc_tokenandmin_depositparametersTest Evidence