Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularised and tested MATLAB code (ustar_cp) #35

Draft
wants to merge 715 commits into
base: main
Choose a base branch
from

Conversation

dorchard
Copy link
Member

@dorchard dorchard commented Sep 26, 2024

This PR collects all the progress on writing a comprehensive test suite for the MATLAB code along with modularised version of the MATLAB for even more fine-grained input-output testing.

  • 375 launch.m @isaacaka
    • Tests
    • Refactored
    • Translated all but saveResult function
    • Translated saveResult function
  • 231 cpdAssignUStarTh20100901.m @j-emberton (aim for 31/01) modularised cpdAssign #68
    • Tests
    • Some extra tests for MATLAB things
    • Refactored
    • Translated
  • 146 cpdBootstrapUStarTh4Season20100901.m @dorchard (aim to do 30/01)
    • Tests
    • Refactored
    • Stats code translated
    • Translated
  • 136 cpdBootstrapUStarTh20100901.m
  • 113 runCpdBootstrapUStarTh4Season20100901CAF.m
  • 188 cpdEvaluateUStarTh20100901.m (as we will use the 4Season instead)
  • 184 cpdEvaluateUStarTh4Season20100901.m @isaacaka
    • Tests
    • Refactored
    • Some parts translated
    • Translated initializeParameters
    • Translated top-level
  • 179 cpdFindChangePoint20100901.m @isaacaka (aim to finish 29/01) Pythonise, test, and refactor cpdFindChangePoint function #57
    • Tests
    • Refactored
    • Translated

Some of these below may be superfluous- check that it's used first.

  • 70 fcFigLoc.m
  • 68 fcDatetick.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 62 fcBin.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 61 cpdFmax2pCp3.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 60 fcNaniqr.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 52 cpdFmax2pCp2.m @dorchard / @j-emberton
    • Tests
    • Refactored
    • Translated
  • 23 fcReadFields.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 19 fcDoy.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 19 fcDatevec.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 11 fcr2Calc.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 6 fcEqnAnnualSine.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 5 fcx2colvec.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 2 fcx2rowvec.m @j-emberton
    • Tests
    • Refactored
    • Translated

@dorchard
Copy link
Member Author

Note that we are focussing on the '4Season' pathway for the moment and then we will try to unify these with the non 4season version which have a small delta.

ma595 pushed a commit that referenced this pull request Oct 17, 2024
dorchard and others added 30 commits February 12, 2025 14:42
Pulling in updates to cpdEvaluate and cpdBootstrap
Co-authored-by: James Emberton <60827102+j-emberton@users.noreply.github.com>
Co-authored-by: James Emberton <60827102+j-emberton@users.noreply.github.com>
Move differential tests into their own files
Write documentation on our approach  + some conftest cleanup
Pythonise launch

Translation of launch to python

Mock of save result function and cpdAssign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants