-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial slide fixes for ICCS summer school 24 #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seem sensible.
One comment is to drop the 'AZ' from @jdenholm's affiliation and make him UoC or something, as I know they are picky about what their name appears on.
Any suggestions on how to make the actual speakers' names stand out on the title page? i.e. with some quarto emphasis effect? I wasn't able to figure this out quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from me.
Regarding the formatting question - my suggestion would be to put yourself and Surbhi on the title slide to make it clear who is teaching.
What you could do is put a note on the subsequent slide with license and repo links etc to say it is based on the workshop developed by Jim and I. If you could also add a citation to the JOSE paper there that would be wonderful.
I will approve the PR now, as this is not a critical blocker, but that change would be appreciated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll attempt to address Jack's comments first. |
This PR fixes minimal aspects of the workshop's accompanying slides in readiness for the 2024 edition of the ICCS summer school. There is scope to add more.
I have added Surbhi and I as additional authors. I would like to emphasise that we are teaching the session, if possible. @jatkinson1000 do you you have any formatting suggestions?
Closes part of #61