chore(wren-ui): fix page size selector not working on SQL pairs table#2156
chore(wren-ui): fix page size selector not working on SQL pairs table#2156okayhooni wants to merge 1 commit intoCanner:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pagination configuration in the ManageQuestionSQLPairs component was enhanced to support configurable page size selection while maintaining the default page size of 10 and preserving the existing behavior of hiding pagination on a single page. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The page size dropdown on the SQL Pairs management page (
/knowledge/question-sql-pairs) is visible but non-functional — selecting 20, 50, or 100 has no effect and the table always shows 10 rows.Cause
pageSize: 10was hardcoded in the Ant DesignTablepagination config, which overrides user selection on every render.Fix
Replace
pageSizewithdefaultPageSizeand explicitly enableshowSizeChangerwithpageSizeOptionsso the dropdown works as expected.Summary by CodeRabbit