Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update proto, swagger and fix script #112

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

dongsam
Copy link
Collaborator

@dongsam dongsam commented Aug 4, 2023

Description

Currently, proto-related makefile commands and scripts are not working properly depending on the local environment.

The PR did the following

  1. The command has been modified to operate the same locally through the docker environment
  2. remove proto and swagger config of deprecated/removed modules (fees, vesting, claims, incentives, recovery)
  3. organized the format of the existing proto files
  4. With the above information reflected, it has been regenerated into the latest proto pb.go, pb.gw.go, swagger, statik

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dongsam dongsam mentioned this pull request Aug 4, 2023
17 tasks
@dongsam dongsam marked this pull request as ready for review August 4, 2023 02:22
@tkkwon1998 tkkwon1998 merged commit 3ea39d9 into Canto-Network:main Aug 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants