Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookies management support #95

Merged
merged 7 commits into from
Dec 31, 2023
Merged

Add cookies management support #95

merged 7 commits into from
Dec 31, 2023

Conversation

monokaijs
Copy link

I've recently working on a project which I have to manually handle the cookie (credentials) in the client-side.
I've modified the plugin so it can read In-app Browser cookies by url. A httpOnly filter also has been implemented.

Example:
InAppBrowser.

import { InAppBrowser } from '@capgo/inappbrowser';

const webUrl = "https://m.facebook.com";

InAppBrowser.open(webUrl);

// Read the cookies after 10 seconds
setTimeout(() => {
  InAppBrowser.getCookies({
    url: webUrl
  }).then(console.log);
}, 10 * 1000);

Hope this helps.

Cheers,

@monokaijs monokaijs changed the title Add get cookies support Add cookies management support Nov 28, 2023
@monokaijs
Copy link
Author

@riderx, please check this out, I need these changes available on production.

Thank you.

@riderx
Copy link
Contributor

riderx commented Dec 29, 2023

@monokaijs sorry i didn't saw your message in all notifs :/

@riderx riderx reopened this Dec 29, 2023
@riderx
Copy link
Contributor

riderx commented Dec 29, 2023

I can merge it now, if you tell me it's still good

@riderx
Copy link
Contributor

riderx commented Dec 29, 2023

Just need to run lint in local, and fix

@monokaijs
Copy link
Author

I have the modified version of this plugin in my production project and it's working properly.

@riderx
Copy link
Contributor

riderx commented Dec 31, 2023

Ok thanks I will fix the lint and merge it then

@riderx
Copy link
Contributor

riderx commented Dec 31, 2023

ios was not building at all, so i had to fix it, last check and it should be good

@riderx riderx merged commit 57dca5f into Cap-go:main Dec 31, 2023
4 of 6 checks passed
@riderx
Copy link
Contributor

riderx commented Dec 31, 2023

ios was not building at all, so i had to fix it, thanks for the work !

@KkatieJ
Copy link

KkatieJ commented Aug 19, 2024

Why was the option to clear all cookies removed?
Nice that it works for your project, but now it causes trouble in mine 👎
Couldn't both options co-exist?

@riderx
Copy link
Contributor

riderx commented Aug 20, 2024

This was not intentional, I will revert the tiny change who cause that

@riderx
Copy link
Contributor

riderx commented Aug 20, 2024

This should be back in last version

@KkatieJ
Copy link

KkatieJ commented Aug 20, 2024

Thanks a lot! Very much appreciated, but I think the last version failed build?

@riderx
Copy link
Contributor

riderx commented Aug 21, 2024

Correct, I made the change direct on GitHub, i did on my mac now i checked the build it's good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants