Skip to content

Fix LedgerEvent serialization and afferent property test #19

Fix LedgerEvent serialization and afferent property test

Fix LedgerEvent serialization and afferent property test #19

Triggered via push September 22, 2023 07:54
Status Success
Total duration 1m 17s
Artifacts

check-hlint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
build
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L132
Warning in Reward in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(PoolKeyHash)" ▫︎ Perhaps: "PoolKeyHash"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L287
Warning in eventCodecVersion in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(Z {})" ▫︎ Perhaps: "Z {}"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L288
Warning in eventCodecVersion in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(Z {})" ▫︎ Perhaps: "Z {}"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L289
Warning in eventCodecVersion in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(Z {})" ▫︎ Perhaps: "Z {}"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L290
Warning in eventCodecVersion in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(Z {})" ▫︎ Perhaps: "Z {}"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L291
Warning in eventCodecVersion in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(Z {})" ▫︎ Perhaps: "Z {}"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L292
Warning in eventCodecVersion in module Cardano.Node.LedgerEvent: Redundant bracket ▫︎ Found: "(Z {})" ▫︎ Perhaps: "Z {}"
build: cardano-node/src/Cardano/Node/LedgerEvent.hs#L470
Warning in serializeEvent in module Cardano.Node.LedgerEvent: Eta reduce ▫︎ Found: "serializeEvent codecVersion event = serialize' codecVersion event" ▫︎ Perhaps: "serializeEvent = serialize'"
build: cardano-node/src/Cardano/Node/Run.hs#L182
Suggestion in runNode in module Cardano.Node.Run: Avoid lambda ▫︎ Found: "\\ e\n -> BS.hPut h\n $ serializeEvent\n (eventCodecVersion event)\n (AnchoredEvent (getOneEraHash headerHash) slotNo e)" ▫︎ Perhaps: "BS.hPut h\n . serializeEvent (eventCodecVersion event)\n . AnchoredEvent (getOneEraHash headerHash) slotNo"
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/