Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-7979 Provide support for sending ledger events over a TChan #1

Merged
merged 10 commits into from
Dec 22, 2023
Merged

PLT-7979 Provide support for sending ledger events over a TChan #1

merged 10 commits into from
Dec 22, 2023

Conversation

neilmayhew
Copy link

@neilmayhew neilmayhew commented Dec 1, 2023 •
edited
Loading

This is used by a PR in marconi

@neilmayhew
Copy link
Author

I'd like to refactor runNode so that the socket-based event streaming code is outside it and is provided via a handler in the list of handlers. However, I'll do that in a follow-up PR.

@neilmayhew neilmayhew mentioned this pull request Dec 1, 2023
Closed
@neilmayhew
Copy link
Author

Looks there's some linting I should take care of

@neilmayhew
Copy link
Author

I've fixed the linting errors (all of which were worth fixing) but we can't do much about the remaining errors, especially the ones that are unrelated to our changes.

@neilmayhew neilmayhew merged commit cf10ddd into minimal/8.x Dec 22, 2023
6 of 15 checks passed
@neilmayhew neilmayhew deleted the PLT-7979-use-TChan branch December 22, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koslambrou koslambrou koslambrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilmayhew @koslambrou