Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-2770: Handler unit tests part 3 #1322

Merged
merged 21 commits into from
Aug 4, 2023
Merged

A0-2770: Handler unit tests part 3 #1322

merged 21 commits into from
Aug 4, 2023

Conversation

lesniak43
Copy link
Contributor

@lesniak43 lesniak43 commented Aug 1, 2023 •
edited
Loading

Description

Further unit tests of the Handler.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests

@lesniak43 lesniak43 marked this pull request as ready for review August 1, 2023 16:45
kostekIV
kostekIV reviewed Aug 3, 2023
View reviewed changes
finality-aleph/src/sync/handler/mod.rs Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Show resolved Hide resolved
finality-aleph/src/sync/mock/backend.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/mock/backend.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Outdated Show resolved Hide resolved
fixxxedpoint
fixxxedpoint requested changes Aug 4, 2023
View reviewed changes
finality-aleph/src/sync/handler/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/sync/handler/mod.rs Show resolved Hide resolved
lesniak43 and others added 7 commits August 4, 2023 10:41
@lesniak43 @kostekIV
Update finality-aleph/src/sync/mock/backend.rs
c80bdb2 
Co-authored-by: kostekIV <27210860+kostekIV@users.noreply.github.com>
@lesniak43 @kostekIV
Update finality-aleph/src/sync/handler/mod.rs
46569f6 
Co-authored-by: kostekIV <27210860+kostekIV@users.noreply.github.com>
@lesniak43 @kostekIV
Update finality-aleph/src/sync/handler/mod.rs
c5237cc 
Co-authored-by: kostekIV <27210860+kostekIV@users.noreply.github.com>
fix
a0794aa
Merge branch 'main' into A0-2770-handler-unit-tests-part-3
e418531
fix
d447737
fix
55af324
@lesniak43 lesniak43 added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit e96005e Aug 4, 2023
46 checks passed
@lesniak43 lesniak43 deleted the A0-2770-handler-unit-tests-part-3 branch August 4, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixxxedpoint fixxxedpoint fixxxedpoint approved these changes

@kostekIV kostekIV kostekIV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesniak43 @kostekIV @fixxxedpoint