Fix "Not Applied" status filter incorrectly checking status types instead of roles

[Copilot]

The "Not Applied" status filter was showing families that had applied to roles because the filtering logic checked against status types (Prospective, Approved, etc.) instead of actual volunteer roles.

Changes

Fixed familyHasNoValidStatuses() and familyMemberHasNoValidStatuses()

• Changed from iterating statusFilters to roleFilters (excluding catchAllLabel)
• Now correctly checks if family/individual has no approvals across all available volunteer roles
• Added optional chaining for safer property access

// Before: checked status types
return statusFilters.every((filterOption) =>
  family.volunteerFamilyInfo?.familyRoleApprovals?.[filterOption.key] === undefined
);

// After: checks actual roles
return roleFilters
  .filter((filterOption) => filterOption.key !== catchAllLabel)
  .every((filterOption) =>
    family.volunteerFamilyInfo?.familyRoleApprovals?.[filterOption.key] === undefined
  );

The filter now correctly returns only families/individuals with no role applications.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>"Not Applied" status filter seems to not be working</issue_title>
<issue_description>I entered a volunteer family, applied to all roles (family level and individual), tried to filter by Status: Not Applied, and the family is still showing in the list.

</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes "Not Applied" status filter seems to not be working #1045

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.