Merge pull request #66 from antoinereyt/fix-tests

Fixes tests
CargoSense · Jul 7, 2021 · 3d91857 · 3d91857
2 parents 328a39f + 1c4d79e
commit 3d91857
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/lib/vex/blank.ex b/lib/vex/blank.ex
@@ -36,8 +36,7 @@ defimpl Vex.Blank, for: Map do
   def blank?(map), do: map_size(map) == 0
 end
 
-defimpl Vex.Blank, for: [Date, DateTime, NaiveDateTime] do
-  def blank?(nil), do: true
+defimpl Vex.Blank, for: [Date, DateTime, NaiveDateTime, Time] do
   def blank?(_), do: false
 end
 

diff --git a/test/validations/presence_test.exs b/test/validations/presence_test.exs
@@ -15,8 +15,7 @@ defmodule PresenceTest do
     assert Vex.valid?([date: Date.utc_today()], date: [presence: true])
     assert Vex.valid?([date: NaiveDateTime.utc_now()], date: [presence: true])
     assert Vex.valid?([date: DateTime.utc_now()], date: [presence: true])
-    refute Vex.valid?([date: nil], date: [presence: true])
-    refute Vex.valid?([date: nil], date: [presence: true])
+    assert Vex.valid?([date: Time.utc_now()], date: [presence: true])
     refute Vex.valid?([date: nil], date: [presence: true])
   end
 
@@ -40,9 +39,8 @@ defmodule PresenceTest do
     assert Vex.valid?(%{"date" => Date.utc_today()}, %{"date" => [presence: true]})
     assert Vex.valid?(%{"date" => DateTime.utc_now()}, %{"date" => [presence: true]})
     assert Vex.valid?(%{"date" => NaiveDateTime.utc_now()}, %{"date" => [presence: true]})
-    refute Vex.valid?([date: nil], %{"date" => [presence: true]})
-    refute Vex.valid?([date: nil], %{"date" => [presence: true]})
-    refute Vex.valid?([date: nil], %{"date" => [presence: true]})
+    assert Vex.valid?(%{"date" => Time.utc_now()}, %{"date" => [presence: true]})
+    refute Vex.valid?(%{"date" => nil}, %{"date" => [presence: true]})
   end
 
   test "keyword list, included presence validation" do