Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BarWidgetUI lack of update when modifying its props #558

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Fix BarWidgetUI lack of update when modifying its props #558

merged 3 commits into from
Jan 4, 2023

Conversation

VictorVelarde
Copy link
Contributor

Description

Related to #557

Type of change

  • Fix

Acceptance

Both 'multiple' and simple modes work well when modifying dinamically the props

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@coveralls
Copy link
Collaborator

coveralls commented Jan 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3836921840

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0%) to 71.599%
Totals Coverage Status
Change from base Build 3687971706: -0.0%
Covered Lines: 1879
Relevant Lines: 2435
💛 - Coveralls

@VictorVelarde VictorVelarde force-pushed the fix-bar-widget-update branch from 53aa889 to 0632de2 Compare January 4, 2023 09:52
@VictorVelarde VictorVelarde merged commit 9676c9e into master Jan 4, 2023
@VictorVelarde VictorVelarde deleted the fix-bar-widget-update branch January 4, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorVelarde @coveralls