getSqlEscapedSource: support for databricksRest provider #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
force-pushed
the
bug/sc-442095/support-pinea-prepared-tables-in-databricks
branch
from
776af9d to
130e6b7
Compare
Pull Request Test Coverage Report for Build 11029739616Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 75ed6ca): https://cartodb-fb-storybook-react-dev--pr913-bug-sc-442095-su-qa8hsz2m.web.app (expires Wed, 02 Oct 2024 09:03:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
jmgaya
approved these changes
Sep 25, 2024
| @@ -26,13 +26,15 @@ const fqnParseRegex = { | |||
| `^${databricksIdentifierRegex}(?:\\.${databricksIdentifierRegex})?(?:\\.${databricksIdentifierRegex})?$` | |||
| ) | |||
| }; | |||
| fqnParseRegex[Provider.DatabricksRest] = fqnParseRegex[Provider.Databricks]; | |||
There was a problem hiding this comment.
Suggestion: I'll add this for consistency inside of fqnParseRegex and will extract the Regex, rather than updating the object afterward, increasing (at least, IMHO) this part's readability, e.g.
const databricksRegex = `^${databricksIdentifierRegex}(?:\\.${databricksIdentifierRegex})?(?:\\.${databricksIdentifierRegex})?$`
const fqnParseRegex = {
...
[Provider.Databricks]: databricksRegex,
[Provider.DatabricksRest]: databricksRegex
}
Same applies to nameNeedsQuotesChecker
There was a problem hiding this comment.
Applied more or less.
zbigg
deleted the
bug/sc-442095/support-pinea-prepared-tables-in-databricks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/442095
getSqlEscapedSource&FullyQualifiedNameto supportdatabricksRestprovider type - which is same asdatabricksfrom SQL povType of change
(choose one and remove the others)
Acceptance
Already covered with UT
Basic checklist