Implement source_col param in Isolines service #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrocar
reviewed
Dec 10, 2019
| source_columns = source_manager.get_column_names() | ||
| source_has_id = 'cartodb_id' in source_columns | ||
| if source_col is None: | ||
| source_col = CARTO_INDEX_KEY |
There was a problem hiding this comment.
If this is the default value, we could set it in the method signature and avoid this conditional.
There was a problem hiding this comment.
I didn't want to add this to the header because of the documentation (reference). The index is set as cartodb_id when there is no cartodb_id column in the dataframe, but this is something I want to keep internally. Does it make sense to you?
| source_columns = source_manager.get_column_names() | ||
| source_has_id = 'cartodb_id' in source_columns | ||
| if source_col is None: | ||
| source_col = CARTO_INDEX_KEY | ||
|
|
||
| iso_function = '_cdb_{function}_exception_safe'.format(function=function) | ||
| # TODO: use **options argument? |
There was a problem hiding this comment.
alrocar
approved these changes
Dec 10, 2019
alasarr
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1303.
NOTE: DS tests are only e2e. There is a task to refactor them into unit tests: #1323.