Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
returnstatement was added to theset_habitmethod inapp/controllers/habits_controller.rb.Previously, when
ActiveRecord::RecordNotFoundwas rescued,head :not_foundwas called, but the method continued execution. This resulted in@habitbeingnil, leading to aNoMethodErrorwhen subsequent actions attempted to operate on@habit.The addition of
returnafterhead :not_foundensures that the method execution stops immediately when a habit is not found. This prevents the controller action from proceeding with anil@habitobject.The change resolves the
NoMethodErrorduring habit deletion attempts for non-existent habits, ensuring a proper 404 Not Found response instead of a 500 Internal Server Error. Existing habits can now be deleted successfully.