Skip to content

Conversation

@0xkynz
Copy link
Collaborator

@0xkynz 0xkynz commented Jul 20, 2023

Summary (Please recap what you changed or fixed)

  • Integrate with sentry to catch error in
    • Background
    • API
    • UI

Checklist (If you won't pass this checklist please comment why)

  • I removed all commented or unnecessary code.
  • Provide the screenshots due to UI changed or bug fixed
  • My code has covered these test cases (please list down your tested cases):

@0xkynz 0xkynz force-pushed the feat/#298-integrate-with-sentry branch 3 times, most recently from 234097b to 6a6bb07 Compare July 23, 2023 08:25
@0xkynz 0xkynz changed the title [WIP] Feat: #298 Integrate with sentry Feat: #298 Integrate with sentry Jul 23, 2023
@0xkynz 0xkynz self-assigned this Jul 23, 2023
@0xkynz 0xkynz requested a review from djhahe July 23, 2023 08:26
@0xkynz 0xkynz force-pushed the feat/#298-integrate-with-sentry branch 4 times, most recently from 7d022c2 to 8668d82 Compare July 28, 2023 03:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@0xkynz 0xkynz force-pushed the feat/#298-integrate-with-sentry branch from 8668d82 to 128592d Compare October 12, 2023 06:26
@0xkynz 0xkynz marked this pull request as draft October 12, 2023 06:27
@0xkynz 0xkynz marked this pull request as ready for review October 12, 2023 06:27
@0xkynz 0xkynz changed the title Feat: #298 Integrate with sentry Draft: Feat: #298 Integrate with sentry Oct 12, 2023
@0xkynz 0xkynz changed the title Draft: Feat: #298 Integrate with sentry Feat: #298 Integrate with sentry Oct 12, 2023
@0xkynz 0xkynz marked this pull request as draft October 12, 2023 06:28
@0xkynz 0xkynz changed the base branch from release/1.5.1 to release/1.7.0 October 12, 2023 06:28
@0xkynz 0xkynz force-pushed the feat/#298-integrate-with-sentry branch from 57931fc to 58da521 Compare October 12, 2023 07:34
@0xkynz 0xkynz marked this pull request as ready for review October 12, 2023 09:35
if (
error &&
error.message &&
error.message.match(/Your account has not been created/i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some other errors no need to put to sentry e.g Invalid password

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djhahe
Copy link
Contributor

djhahe commented Oct 17, 2023

leave this to next release

@djhahe djhahe added this to the [CD-Web]1.8.0 milestone Oct 17, 2023
@0xkynz 0xkynz removed this from the [CD-Extension] 1.8.0 milestone Oct 25, 2023
@0xkynz
Copy link
Collaborator Author

0xkynz commented Oct 25, 2023

Just removed from release/1.8.0, for focusing to dApp feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants