Fix excusing override #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remlapmot
approved these changes
Nov 27, 2025
Collaborator
remlapmot
left a comment
remlapmot
left a comment
There was a problem hiding this comment.
Looks good Ryan.
I guess worth bumping the package version to a development version and adding a NEWS bullet.
ryan-odea
added a commit
that referenced
this pull request
Nov 28, 2025
* fixed isExcused getting overwritten * update tests * version bump
remlapmot
pushed a commit
that referenced
this pull request
Dec 8, 2025
* fixed isExcused getting overwritten * update tests * version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building the python version, I noticed
would loop over and replace isExcused at each iteration - this has been resolved to using the loop to in-place replacement the memory location only where treatment == treatment level [i]
Updated tests