Open
Conversation
|
This branch has conflicts that must be resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Gives Pilgrim and Forester a soft skill cap instead of a hard one.
Removed Apprentice Athletics and Knife-Fighting from Pilgrim and gave it Apprentice carpentry and crafting.
Gave Forester Apprentice crafting.
Developer's checklist
Testing Evidence
Spawned in with the virtues. Getting the new skills and the softcap is working, granting +1 to the skills if equal to or above Apprentice skill level.
Why It's Good For The Game
Pilgrim and Forester were always intended to be virtues that allow one to be self-sufficient, with Forester more focused on surviving out in the wilderness and Pilgrim about making the wilderness one's home, similar to a homesteader.
As for the softcap, it has been added to bring them more in line with the other non-combat crafting/lifestyle virtues like Blacksmith's Apprentice or Artificer's Apprentice.
Changelog
🆑
add: Added more things
del: Removed old things
qol: made something easier to use
balance: rebalanced something
code: changed some code
/:cl: