Adds a leathercraftable marksman's cloak at journeyman skill#277
Open
LiquidFirefly wants to merge 8 commits intoCausticCove:mainfrom
Open
Adds a leathercraftable marksman's cloak at journeyman skill#277LiquidFirefly wants to merge 8 commits intoCausticCove:mainfrom
LiquidFirefly wants to merge 8 commits intoCausticCove:mainfrom
Conversation
|
Yes pls this would be awesome |
|
This branch has conflicts that must be resolved |
I AM GOING TO BUST NUT
…Y EMPTY FIELDS AND WEEP
Author
|
it compiles and the item works, I genuinely don't care to fuck with this anymore. The code works, the unit tests hate me SUDDENLY even though they were fine with every bit of this code last week. |
Author
|
The file there was conflicts with isn't even TOUCHED anymore so fuck it. |
Author
|
I don't even know what that dogshit test is checking for because the item uses SIX LEATHER and TWO ROPE (IE 6 fucking fiber) and salvages into a single fucking cloth and a fiber (SO THREE FIBER) on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a leathercraftable marksman's cloak at journeyman skill. It functions exactly like a tossblade belt, and can hold six pistols, a powderflask, and an ammo pouch.
Developer's checklist
Testing Evidence
Coat is craftable with leather, requires a drying rack, uses the longcoat as a placeholder sprite, and requires six leather and two ropes. Storage does not function on a grid, and instead uses two clean-looking slots that only accept quiver subtypes and the powderflask. The only acceptable quiver subtypes are sling bullet pouches and ammo pouches, actual quivers are too large.
Why It's Good For The Game
You can already make janky as hell storage-monstrosities for thirty+ guns. This is just QOL for people who don't want to use hotkeys to have an upgradable storage. It also doesn't require a bunch of enchanting weirdness, and only requires leathercraft.
Changelog
Syri 🆑
Add: Added the marksman's cloak.
/:cl: