Skip to content

Comments

Adds a leathercraftable marksman's cloak at journeyman skill#277

Open
LiquidFirefly wants to merge 8 commits intoCausticCove:mainfrom
LiquidFirefly:Gunshit
Open

Adds a leathercraftable marksman's cloak at journeyman skill#277
LiquidFirefly wants to merge 8 commits intoCausticCove:mainfrom
LiquidFirefly:Gunshit

Conversation

@LiquidFirefly
Copy link

@LiquidFirefly LiquidFirefly commented Jan 8, 2026

About The Pull Request

Adds a leathercraftable marksman's cloak at journeyman skill. It functions exactly like a tossblade belt, and can hold six pistols, a powderflask, and an ammo pouch.

Developer's checklist

  • I have modularized whatever changes I could.
  • I have marked the start and end of my edits outside the caustic modular folder (if applicable) for changes that I couldn't modularize.
  • It compiled locally, and I tested new features, or potential issues with related features, to the best of my abilities.
  • This change applies mainly to our server, and wouldn't be in a better place upstream / cannot wait until the weekly upstream update.

Testing Evidence

Coat is craftable with leather, requires a drying rack, uses the longcoat as a placeholder sprite, and requires six leather and two ropes. Storage does not function on a grid, and instead uses two clean-looking slots that only accept quiver subtypes and the powderflask. The only acceptable quiver subtypes are sling bullet pouches and ammo pouches, actual quivers are too large.

Why It's Good For The Game

You can already make janky as hell storage-monstrosities for thirty+ guns. This is just QOL for people who don't want to use hotkeys to have an upgradable storage. It also doesn't require a bunch of enchanting weirdness, and only requires leathercraft.

Changelog

Syri 🆑
Add: Added the marksman's cloak.
/:cl:

@JohnnyJohnJohnson
Copy link

Yes pls this would be awesome

@SpadesNeil
Copy link

This branch has conflicts that must be resolved

@LiquidFirefly
Copy link
Author

it compiles and the item works, I genuinely don't care to fuck with this anymore. The code works, the unit tests hate me SUDDENLY even though they were fine with every bit of this code last week.

@LiquidFirefly
Copy link
Author

The file there was conflicts with isn't even TOUCHED anymore so fuck it.

@LiquidFirefly
Copy link
Author

LiquidFirefly commented Jan 14, 2026

I don't even know what that dogshit test is checking for because the item uses SIX LEATHER and TWO ROPE (IE 6 fucking fiber) and salvages into a single fucking cloth and a fiber (SO THREE FIBER) on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants