-
Notifications
You must be signed in to change notification settings - Fork 2
Clarify <endPoint> and <streamName> usage, improve guidance and style #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
jobl
commented
Jun 21, 2025
- Rewrote sections explaining how to specify and
- Added clearer examples for both hostname and full URL use cases
- Restyled to use GitHub-flavored Markdown for better rendering
- Enhanced readability and consistency across the documentation
…ance and style - Rewrote sections explaining how to specify <endPoint> and <streamName> - Added clearer examples for both hostname and full URL use cases - Restyled to use GitHub-flavored Markdown for better rendering - Enhanced readability and consistency across the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better now. We could even go simpler by removing the streamName
and iceServer
fields, which would make clear that those fields are optional :
streamName: <streamName>,
iceServer: {
urls: ['turn:' + <endPoint> + ':3478?transport=tcp', 'turn:' + <endPoint> + ':3478'],
username: 'ceeblue', credential: 'ceeblue'
}
If we want to, we can remove the 4 lines, then say that alternatively the user can :
- Use the
<host>
+<streamName>
format (which must be extracted from the URL), - Add the
iceServer
field.
Yes, I've re-thought it only on |
> - Relaying adds latency. | ||
> - TURN over TCP/TLS doesn’t handle congested networks well, video can freeze or slow down. | ||
> | ||
> Use TURN wisely, it should be your last resort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a doubt regarding this because TURN is enabled by default, maybe we could explain it
> See the type `Params` in the file [Connect.ts from web-utils](https://github.com/CeeblueTV/web-utils/blob/main/src/Connect.ts) for more details about the parameters of connection. | ||
> [!IMPORTANT] | ||
> | ||
> Given this URL: `wss://example.com/webrtc/in+aa3221a5-a715-4215-9e9d-711f2c9cfc45`\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to expose the Ceeblue stream ID format?