Implement orbital precession#2364
Draft
pedro-fixingstuff wants to merge 3 commits intoCelestiaProject:masterfrom
Draft
Implement orbital precession#2364pedro-fixingstuff wants to merge 3 commits intoCelestiaProject:masterfrom
pedro-fixingstuff wants to merge 3 commits intoCelestiaProject:masterfrom
Conversation
|
Contributor
Author
|
The latest commit fails to build as it is right now |
Contributor
|
Regarding precession causing the no-fading orbit to be incomplete, we might want to instead draw the Keplerian orbit at that instant (a Keplerian orbit with the current longitude of ascending node and argument of periapsis). This is the approach Universe Sandbox uses for its equivalent orbit render mode, and in absence of fading, I think it's about the best option we have to render these orbits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This adds two new parameters for modeling of nodal and apsidal precession:
NodalPrecessionPeriodandApsidalPrecessionPeriod. The default unit for both is years.Example syntax (orbit data from 16 Cyg Bb):
For the following images, I've set
OrbitPeriodsShownto 3.0 in celestia.cfg.Nodal precession:

Apsidal precession:

One issue is that the orbit paths look incomplete (this is with fading disabled). I wonder if using some parameter other than period (such as eccentric anomaly) for sampling the orbit would address that.

I'm not sure if the equations used are correct either.