Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace interstellar-objects trajectory with hyperbolic orbit definition #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajtribick
Copy link
Contributor

@ajtribick ajtribick commented Dec 30, 2023

Not sure what license the .ssc file is under, so not annotating it for now. @SevenSpheres if you have further information here, will add the SPDX-FileCopyrightText and SPDX-License-Identiifer tags.

In any case, removing the xyzv files means two fewer files to worry about tracking down license information.

Potentially could move this file to the data directory?

Breaks 1.6.x compatibility.

@pedro-fixingstuff
Copy link
Contributor

Would using periods in years keep them compatible with 1.6.x?

I see you did round the parameter values from the sources, While I think storing all of them as we've been doing so far for other data files isn't ideal (especially due to Celestia's single-precision floating point arithmetic), I believe we should reach an agreement on this before other files are updated.

@ajtribick
Copy link
Contributor Author

Potentially. The velocity calculations for hyperbolic orbits in 1.6.x were completely wrong, which could affect some of the orbit rendering code in unpredictable ways.

@SevenSpheres
Copy link
Contributor

  • Anyone contributing to this repository automatically releases their own contributions under the GPL.
  • If that's not sufficient, I release all my contributions to CelestiaContent under CC-BY.
  • As with many ssc files, some content is taken from Celestia Origin. You can discuss with them if they want to release it under a different license.

@mattiaverga
Copy link

  • Anyone contributing to this repository automatically releases their own contributions under the GPL.

Well, not necessarily... AFAIK in order to be "legally conformant" a DCO signing requirement should be enforced.
https://opensource.com/article/18/3/cla-vs-dco-whats-difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants