DO NOT MERGE. Intro serializer lib with json and protobuf. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use gogo protobuf
use bytes for rv map in transit for protobuf not support struct as map key separate type def separate type def separate type def
…ling data from region manager protobuf auto-gen files and hard-coded to protobuf serializer for pulling data from region manager handle time in protobuf
only wait for empty pulls
yb01
requested review from
Sindica,
q131172019 and
sonyafenge
and removed request for
Sindica,
q131172019 and
sonyafenge
Sindica
reviewed
Jul 27, 2022
| @@ -118,6 +112,9 @@ func (a *Aggregator) Run() (err error) { | |||
| if eventProcess { | |||
| a.postCRV(c, crv) | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Typically, there will be a comparison between actual data size and batch size. If data size == batch size, no need to wait for subsequent pull. Wait a bit if data size < batch size. Without waiting, even a single event can cause immediate subsequent pull. This seems a bit misaligned with 100ms for empty pull.
There was a problem hiding this comment.
good point. will fix.
There was a problem hiding this comment.
currently the batch size is not used, so comparing with expected ( batch size ) and the actually got data ( the length ) won't help here for now.
since the goal is to avoid waitless pull()s from the aggregator to avoid busy cpu spins, we will check the durations of pull() and/or the processEvent() and make adjustment of wait time here.
|
FYI, this change caused 20% performance lost for distributor_concurrency_test (for 2M events, 200K events seem ok) when metrics is disabled. |
q131172019
reviewed
Jul 28, 2022
|
|
||
| // NewRegionNodeEvents creates a Region Node Events handler with the given logger | ||
| // | ||
| func NewRegionNodeEventsHander() *RegionNodeEventHandler { | ||
| return &RegionNodeEventHandler{} | ||
| return &RegionNodeEventHandler{ | ||
| // serializer: localJson.NewSerializer("foo", false), |
There was a problem hiding this comment.
This commented line should be removed, right?
There was a problem hiding this comment.
yeah, i should have removed it. will do.
q131172019
reviewed
Jul 28, 2022
q131172019
reviewed
Jul 28, 2022
q131172019
reviewed
Jul 28, 2022
There was a problem hiding this comment.
Suggest to add an instruction/steps about how to use protobuf to automatically generate files.
Reference: CentaurusInfra/arktos#1281.
Also, before merge into main branch, can this PR be tested in GCE env because too many files are modified by this PR?
|
some perf comparison for the event queue change in commit fb9b951 --- server side metrics: |
|
on hold, should extra perf for the GRS is needed. |
Sindica
reviewed
Sep 14, 2022
| @@ -201,7 +202,7 @@ func (eq *NodeEventQueue) getAllEventsSinceResourceVersion(rvs types.InternalRes | |||
| } | |||
| } | |||
|
|
|||
| nodeEvents := make([]*types.NodeEvent, 0) | |||
| nodeEvents := make([]*types.NodeEvent, 0, 1000) | |||
There was a problem hiding this comment.
By test, this change does not improve performance.
|
|
|
put this PR on hold. |
yb01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR contains changes in two major commits for
fix in issue #102