Merged
Conversation
Motivation ---------- Keep up to date. Modifications ------------- - Drop the out-of-support .NET 6 target and add a .NET 9 target. - Use file-scoped namespaces. - Update various NuGet dependencies and update to xUnit v3. - Update GitHub Actions and GitVersion. - Switch to GitHubActionsTestLogger. - Update to C# 13. - Reduce code duplication by forwarding RunSync calls with no state to the methods which take state parameters. This may also reduce JIT code size in some scenarios. - Add OverloadResolutionPriority to RunSync calls so C# 13 and later prefers the Task overload to the ValueTask overload. This simplifies usage by consumers. - Use a strong type for work items instead of a ValueTuple.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CenterEdge.Async library by updating target frameworks, dependencies, and code to use newer .NET features. The primary goals are dropping out-of-support .NET 6, adding .NET 9 support, and improving API usability with C# 13 features.
Key changes include:
- Updated target frameworks from .NET 6 to .NET 9 and upgraded to C# 13
- Refactored AsyncHelper to reduce code duplication by forwarding simple RunSync calls to stateful methods
- Added OverloadResolutionPriority attributes to prefer Task overloads over ValueTask when both are applicable
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| OverloadResolutionPriorityAttribute.cs | Adds internal polyfill for C# 13 overload resolution priority feature |
| CenterEdge.Async.csproj | Updates target frameworks, language version, and package dependencies |
| AsyncHelper.cs | Modernizes with file-scoped namespace and reduces duplication by forwarding calls |
| AsyncHelperTests.cs | Updates tests to use cleaner syntax and TestContext cancellation tokens |
| Build/CI files | Updates GitHub Actions, GitVersion, and test runner configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brant Burnett <bburnett@centeredgesoftware.com>
RobRobertsCE
approved these changes
Sep 29, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Keep up to date.
Modifications