Skip to content

Fill celery-flower command arguments from values #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fill celery-flower command arguments from values #72

wants to merge 2 commits into from

Conversation

Ceridan
Copy link

@Ceridan Ceridan commented Jul 15, 2021

There are two changes in this PR:

  1. Internal port. Currently, you may change service.internalPort in Values, but flower always starts with the default port. I think it is a good idea to provide a proper port as flower command argument.
  2. The broker value is hardcoded. It looks like a common practice to provide your own broker: it could be other credentials to RabbitMQ or maybe you may want to use Redis instead of RabbitMQ. I moved the broker argument to .Values.command.broker, so you may override it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ceridan