Skip to content

Conversation

Vlad0n20
Copy link
Contributor

Purpose

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8960?atlOrigin=eyJpIjoiOGM2M2M5OTA4MzQ5NDE4MzhjMDI3ZDUwZjRlOGRlOWMiLCJwIjoiaiJ9

@Vlad0n20 Vlad0n20 changed the base branch from develop to feature/pbs-25-19 September 24, 2025 17:49
'new_date': str(new_date)
},
log_date=timezone.now(),
should_hide=False,
Copy link
Contributor

@ihorsokhanexoft ihorsokhanexoft Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be True so that this log doesn't update last_logged date of the registration as it's an admin action. This parameter is responsible for updating or not last_logged attribute

osf.io/osf/models/mixins.py

Lines 144 to 145 in 376c526

if not log.should_hide:
self.last_logged = last_logged

After that, assign this ticket to Yuhuai for code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants