[DO NOT MERGE] #119 global filter and #159 code sanitisation #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
#159: I created a file that contains all the columns's name as variables. This file has no effect on the current work, because it doesn't get called anywhere. To make this file effective, you will use Find and Replace, and change the raw strings to variables wherever you find them. We will not proceed any futher on this issue, because we have other issues to focus on. If you find it useful, we will leave it here for future developers.
#119:
I made a global filter file (my_project/callbackMonthHourFilter.py), containing global callbacks. There is an issue with this file that I have to comment out the callbacks. The callback will throw error because it listens to all the ID, including those that are not currently rendered on the tab. Would you have any coding pattern to solve this?
I set the initial values for all the month/time filters based on the global values. However, the charts on the tab when initally loaded are not based on the filter, they used the default values of [1,12], [1,24], no invert. The reason for this is because of this
if time_filter:
. When first initally loaded, time_filter is 0, thus this if-else is not executed => the dataframe is not filtered.