Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart change units should not move #86

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

Ruixin126
Copy link
Collaborator

Adaptive EN, Adaptive Ashrae, PMV - EN, PMV-Ashrae charts bug fixing

Fixed the issue where the chart's content position remained unchanged when converting the X and Y axes from Celsius to Fahrenheit. Ensured that the data in the chart stays in the correct position after changing the unit of the axes.

Type of change

  • Bug fixing

Make sure the chart in correct position after change the unit of axes in Adaptive EN
image
image

Make sure the chart in correct position after change the unit of axes in Adaptive Ashrae
image
image

Make sure the chart in correct position after change the unit of axes in PMV Ashrae
image
image

Checklist

  • The code has been formatted via black

@Xuhui-Wang-9988
Copy link
Collaborator

nice change. from now now on the hover annotation should not remove during mouse moving anymore

@Yannnnnnny
Copy link
Collaborator

all good

@Yannnnnnny Yannnnnnny self-requested a review October 27, 2024 08:54
@ZhouTongworking
Copy link
Collaborator

all good

@Marcusxixi Marcusxixi self-requested a review October 27, 2024 12:59
Copy link
Collaborator

@Marcusxixi Marcusxixi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Copy link
Collaborator

@jiadongZhangWorkIn jiadongZhangWorkIn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants