-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart change units should not move #86
Open
Ruixin126
wants to merge
4
commits into
CenterForTheBuiltEnvironment:development
Choose a base branch
from
ZhouTongworking:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chart change units should not move #86
Ruixin126
wants to merge
4
commits into
CenterForTheBuiltEnvironment:development
from
ZhouTongworking:development
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nice change. from now now on the hover annotation should not remove during mouse moving anymore |
Xuhui-Wang-9988
approved these changes
Oct 27, 2024
all good |
Yannnnnnny
approved these changes
Oct 27, 2024
all good |
Marcusxixi
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
jiadongZhangWorkIn
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine
ZhouTongworking
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptive EN, Adaptive Ashrae, PMV - EN, PMV-Ashrae charts bug fixing
Fixed the issue where the chart's content position remained unchanged when converting the X and Y axes from Celsius to Fahrenheit. Ensured that the data in the chart stays in the correct position after changing the unit of the axes.
Type of change
Make sure the chart in correct position after change the unit of axes in Adaptive EN
Make sure the chart in correct position after change the unit of axes in Adaptive Ashrae
Make sure the chart in correct position after change the unit of axes in PMV Ashrae
Checklist