Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge function_selection:compare, pmv-ashrea, psychrometric air temperature into just one function "psy_pmv #90

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

karlliu666
Copy link
Collaborator

@karlliu666 karlliu666 commented Oct 30, 2024

The chart and annotation including the si and ip modes can be displayed correctly. The filled area (blue and grey) and light point(input1) with dark point(input2) can be moved based on the user selection on those six attributes.

  • Added "psychrometric air temperature" charts into the compare of function selection in the project, and combined 'PMV-ASHREA' and 'PMV EN' into one function to simplify the code into the compare of function selection in the project.

  • The attributes including 'Relative humidity', 'Dry-bulb Temperature' and comfort level can be shown in the compare of function selection

  • There are two filled areas blue and grey that are on input 1 and 2 respectively.

  • If one of the points is outside the comfort area, the warning "not comply with the one standard" can be shown on the chart.

  • The relevant exchanges including x-axis, input box, and the returned value on the top of the chart can be displayed on two modes 'si' and 'ip'

  • The relevant value in Annotation can be shown on the two modes 'si' and 'ip'

The string value of "complies with ASHRAE Standard 55-2023" can be adjusted by user changing the input of temperature or comfort area:

unit test:
User can select "compare" selection functionality and then choose the psychrometric air temperature, and set inputs of air temperature, mean radiant temperature, air speed, relative humidity, metabolic rate (met)and clothing level (clo). The chart will generate the visualization. The annotation will be generated and change the value based on the current mouse position. The chart size adapts to the current UI interface.

pic1

Can manually select SI or IP unit:

pic2

When the light dot inside the neutral sensation region and the dark dot outside the neutral sensation region, the corresponding ‘✔’(comply with ASHRAE Standard 55-2023),’✘‘ (Does not comply with ASHRAE Standard 55-2023), and both of their sensation will be displayed above the show result.
pic (SI or IP unit:)

pic3ip
pic3si

Likewise, the dark dot inside the neutral sensation region and the light dot outside the neutral sensation region, the corresponding '✘ Does not comply with ASHRAE Standard 55-2023' and both of their sensation will be displayed above the show result.
pic (SI or IP unit:)

pic4ip
pic4si

The column names are changed if the units changing from SI and IP

pic5

Copy link
Collaborator

@Xuhui-Wang-9988 Xuhui-Wang-9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for this commit

Copy link
Collaborator

@Mitarashiharuto Mitarashiharuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the result bar and resut dot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants