Skip to content

Gallica: automate restart after failed HTTP requests #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

BeritJanssen
Copy link
Contributor

There is a throttle on the Gallica API, which caused periodical crashes & necessity for manual restarts. This branch automates those restarts, and it now seems to run smoothly (albeit very slowly) over the remaining Figaro data.

Copy link
Contributor

@JeltevanBoheemen JeltevanBoheemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this solution.

It being slow is not such a bad thing, as long as it keeps going. You could experiment with a dynamic timeout, e.g. wait 5s on the first retry, 10s on the next etc.

@BeritJanssen BeritJanssen merged commit 1e47670 into develop Jan 22, 2025
1 check passed
@BeritJanssen BeritJanssen deleted the feature/gallica-restart branch January 22, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants