Skip to content

Conversation

@lukavdplas
Copy link
Contributor

@lukavdplas lukavdplas commented Oct 30, 2025

This tries to untangle the barchart components somewhat, by separating the logic to fetch the data from the logic to render the graph/table. E.g. TimelineComponent uses a TimelineData object that handles the data fetching.

The logic in BarchartData/HistogramData/TimelineData is mostly lifted verbatim from BarchartComponent/HistogramComponent/TimelineComponent, but I had to make some changes because the data object is not embedded in the component lifecycle in the same way.

Note for review: the whole point of this is that these modules were a tangled mess (now slightly less so), so please don't spend too much time on this. Just scan the code to see if anything stands out.

Base automatically changed from feature/explain-api-for-term-frequency to develop January 19, 2026 14:12
@lukavdplas lukavdplas added code quality code & performance improvements that do not affect user functionality frontend changes to the angular frontend labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality code & performance improvements that do not affect user functionality frontend changes to the angular frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant