Feature/dark mode #1973
Draft
Feature/dark mode #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeltevanBoheemen
approved these changes
Jan 15, 2026
Contributor
JeltevanBoheemen
left a comment
JeltevanBoheemen
left a comment
There was a problem hiding this comment.
Nice dropdown.
Very well documented.
Code makes sense.
So my very minor two cents: I find the primary color too dark in dark mode. Maybe explore a slightly less saturated or lighter shade. (again, minor stuff)
| @@ -0,0 +1,67 @@ | |||
| # Styling | |||
Contributor
There was a problem hiding this comment.
Beyond impressed by this documentation.
| import { stylePreset } from './primeng-theme'; | ||
| import { CoreModule } from './core/core.module'; | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Load-bearing whitespace?
| theme$: Observable<Theme>; | ||
|
|
||
| /** Default dark/light preference from the browser/OS */ | ||
| private systemTheme$: Observable<Theme>; |
Contributor
There was a problem hiding this comment.
They're called System Team
| chart: Chart; | ||
|
|
||
| constructor() { } | ||
| constructor() {} |
Contributor
There was a problem hiding this comment.
Non-load-bearing whitespace?
Contributor
|
Just noticed that this is a draft PR. Sorry if the review is premature. |
Contributor
Author
|
Not sure why I marked this as a draft, I think the code is done but I wasn't sure about the colours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dark mode look is mostly just from bulma / primeNG, but I changed some CSS variables to increase contrast for text/borders. I'm not super happy about the look but I guess it's fine?
There is a component to let users pick dark/light mode. Default is "auto", i.e. adapt to system theme. But I would not mind using "light" as the default setting.
I used the
runInIframesetting so Peace Portal always uses the light theme.There is some extra logic to adjust colours for visualisations.