Bugfix/corpus refresh #2004
Open
Bugfix/corpus refresh #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1917 - I can reproduce the bug sometimes but not always, so I don't know if this definitively fixes it, but it should make the corpus refresh more robust at least?
This makes sure that the "search" button for the corpus only becomes clickable after the refresh is complete. Previously, the button would be available immediately so you could, in theory, click "search" before corpora were refreshed. But the refresh doesn't take that long so I'm sceptical that this was the problem.
Also makes a minor fix to the label text in the language dropdown.