CERT 8125 Support Multisig Address Check #83
Conversation
| if not response.ok: | ||
| return None | ||
| data = response.json() | ||
| return MultisigData(**data) |
There was a problem hiding this comment.
Can we ensure data format wont change?
Do we want to try/catch here or we don't expect this to happen?
There was a problem hiding this comment.
Can we ensure data format wont change?
Not really it is dependant on their API
Do we want to try/catch here or we don't expect this to happen?
It would be better to get the validation error and adjust the API to make sure we return the necessary data
| @@ -106,14 +109,20 @@ def verify_price_feed(self) -> None: | |||
| elif res := self.__check_address(address, self.token_providers): | |||
| verified_variables.append(res.price_feed.model_dump()) | |||
| verified_tokens.add(res) | |||
| elif res := self.multisig_api.get_multisig_info(address): | |||
There was a problem hiding this comment.
So our only way to understand if this is multisig, is to try and fetch the data from SafeAPI, and in case of failures/success we move forward?
There was a problem hiding this comment.
Yep, if the API return a valid obj then this address is a multisig else its not
| from quorum.apis.multisig.safe_api import SafeAPI | ||
|
|
||
|
|
||
| def test_safe_api(): |
There was a problem hiding this comment.
As a continuation for the comment above, can we verify that the SafeAPI return None for non-multisig addresses?
nivcertora
dismissed stale reviews from yoav-el-certora and liav-certora
via
f37f111
https://certora.atlassian.net/browse/CERT-8125
PR Message
Summary:
This PR introduces multisig support by adding a new module in src/quorum/apis/multisig/ with a SafeAPI class to interact with the Safe Multisig API.
The multisig integration is incorporated into the PriceFeedCheck class so that multisig wallet data is verified alongside other price feed providers.
A new test (test_mutisig_api.py) has been added to ensure that multisig data is correctly retrieved and parsed.
Key Changes:
Added src/quorum/apis/multisig/safe_api.py with a MultisigData model and SafeAPI class (using a singleton decorator).
Modified src/quorum/checks/price_feed.py to:
Instantiate SafeAPI and query multisig data for addresses.
Append multisig results to the list of verified variables.
Print a multisig-specific summary of validation results.