Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed all conf files to gconf CERT-4617 #37

Merged
merged 2 commits into from
Jan 4, 2024
Merged

renamed all conf files to gconf CERT-4617 #37

merged 2 commits into from
Jan 4, 2024

Conversation

urikirsh
Copy link
Contributor

@urikirsh urikirsh commented Jan 2, 2024

Rename all the gambit config files to have the suffix .gconf

@urikirsh urikirsh changed the title renamed all conf files to gconf renamed all conf files to gconf CERT-4617 Jan 2, 2024
@urikirsh urikirsh added the enhancement New feature or request label Jan 2, 2024
@urikirsh urikirsh self-assigned this Jan 2, 2024
chandrakananandi
chandrakananandi reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@chandrakananandi chandrakananandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I assume json extensions continue to work still since we didn't change the code in any way, yes?

@urikirsh
Copy link
Contributor Author

urikirsh commented Jan 3, 2024

Thanks for the PR! I assume json extensions continue to work still since we didn't change the code in any way, yes?

Yes. We have to else it would break backwards compatibility. It is just a new convention.

@urikirsh urikirsh merged commit 862cd0f into master Jan 4, 2024
@urikirsh urikirsh deleted the uri/change_conf_file_suffix branch January 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandrakananandi chandrakananandi chandrakananandi approved these changes

Assignees

@urikirsh urikirsh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urikirsh @chandrakananandi