Expose implicit tiling related functionality #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
reviewed
Nov 15, 2023
There was a problem hiding this comment.
@kring looks good to me! I'm not familiar with subtree math so I couldn't verify the mathematical correctness of everything. It looks like all the same tests pass, though, so that's probably good enough :')
I noticed two things but I'll just push a commit for them, then merge once CI passes.
| @@ -198,6 +198,30 @@ TEST_CASE("Test implicit octree loader") { | |||
| } | |||
| } | |||
|
|
|||
| namespace { | |||
There was a problem hiding this comment.
Should these changes also be done in TestImplicitQuadtreeLoader.cpp ?
| } | ||
|
|
||
| /** | ||
| * @brief Computes the bounding volume for an implicit tile with the given ID. |
There was a problem hiding this comment.
I think these comments could use a few extra words so it's easier to distinguish the functions at a glance. I'll add some changes in a commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #750 so merge that first.
Previously, a lot of logic for working with implicit tilesets was buried in
ImplicitQuadtreeLoaderandImplicitOctreeLoader, which are closely tied to the selection algorithm. With this PR, a lot of the functionality is now available in theCesium3DTilesContentlibrary and can be used independent of selection. This is useful when programmatically loading and manipulating a 3D Tiles implicit tileset.