Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WmsRasterOverlay support and UI #670

Merged
merged 11 commits into from
Feb 12, 2024
Merged

add WmsRasterOverlay support and UI #670

merged 11 commits into from
Feb 12, 2024

Conversation

corybarr
Copy link
Contributor

@corybarr corybarr commented Feb 7, 2024

Adds Web Map Service (WMS) support:

image

Test file: WmsTest.zip

Resolves #609

@corybarr
Copy link
Contributor Author

corybarr commented Feb 7, 2024

@r-veenstra I guess on good max ranges on the zoom level. Can you see if they're reasonable?

@corybarr
Copy link
Contributor Author

corybarr commented Feb 7, 2024

@r-veenstra I'm wondering if adding a "Refresh" button to the WMS raster overlay is the best way to handle users' property updates.

@corybarr corybarr marked this pull request as ready for review February 7, 2024 02:42
@corybarr corybarr changed the title add WMSRasterOverlay support and UI add WmsRasterOverlay support and UI Feb 7, 2024
Copy link
Contributor

@lilleyse lilleyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple small comments from me.

src/core/src/OmniWebMapServiceRasterOverlay.cpp Outdated Show resolved Hide resolved
src/core/src/OmniWebMapServiceRasterOverlay.cpp Outdated Show resolved Hide resolved
src/core/src/OmniWebMapServiceRasterOverlay.cpp Outdated Show resolved Hide resolved
src/core/src/UsdNotificationHandler.cpp Outdated Show resolved Hide resolved
src/core/src/UsdNotificationHandler.cpp Show resolved Hide resolved
exts/cesium.usd.plugins/schemas/cesium_schemas.usda Outdated Show resolved Hide resolved
@r-veenstra
Copy link
Contributor

I've done some testing, seems to be working as expected. Comments below.

  • Clicking the Refresh Tiles button on a tileset or Reload All Tilesets in the Cesium Debug window doesn't result in the WMS overlay updating based on latest values - should it?

  • We probably want to include these settings too:
    image

@r-veenstra
Copy link
Contributor

@r-veenstra I guess on good max ranges on the zoom level. Can you see if they're reasonable?

The defaults in there look okay and are consistent with Unreal too

@lilleyse
Copy link
Contributor

lilleyse commented Feb 9, 2024

Clicking the Refresh Tiles button on a tileset or Reload All Tilesets in the Cesium Debug window doesn't result in the WMS overlay updating based on latest values - should it?

Tilesets and raster overlays are now separate things in the C++ layer so OmniTileset would need to explicitly reload the OmniRasterOverlays that it references. @corybarr could you make that fix?

@corybarr
Copy link
Contributor Author

corybarr commented Feb 12, 2024

  • We probably want to include these settings too:
    image

@r-veenstra This is an issue with all raster overlays. I created #675 for this.

@corybarr
Copy link
Contributor Author

Clicking the Refresh Tiles button on a tileset or Reload All Tilesets in the Cesium Debug window doesn't result in the WMS overlay updating based on latest values - should it?

Tilesets and raster overlays are now separate things in the C++ layer so OmniTileset would need to explicitly reload the OmniRasterOverlays that it references. @corybarr could you make that fix?

@lilleyse Added.

@corybarr corybarr merged commit 6d7dcf4 into main Feb 12, 2024
3 checks passed
@corybarr corybarr deleted the add-wms-raster-overlay branch February 12, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Web Map Service Raster Overlays
3 participants