Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing headers. #1197

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add missing headers. #1197

merged 1 commit into from
Aug 30, 2023

Conversation

kring
Copy link
Member

@kring kring commented Aug 29, 2023

These show up as compiler errors when building in non-unity mode.

@cesium-concierge
Copy link

Thanks for the pull request @kring!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

@csciguy8
Copy link
Contributor

I've also fixed these problems in PR #1198 . Jinx.

@kring
Copy link
Member Author

kring commented Aug 30, 2023

Yeah I think this is the third time I've fixed it. I should have opened a PR sooner, but it was always a pain because I was in some other branch.

@csciguy8 csciguy8 self-requested a review August 30, 2023 15:50
Copy link
Contributor

@csciguy8 csciguy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the exact changes I made in PR #1198 . Have already verified they pass both unity and non-unity builds.

@csciguy8 csciguy8 merged commit b4cd856 into ue5-main Aug 30, 2023
25 checks passed
@csciguy8 csciguy8 deleted the missing-headers branch August 30, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants