Skip to content

Commit

Permalink
Address TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeshurun Hembd committed Sep 12, 2024
1 parent 611bcca commit 0350152
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/engine/Source/Scene/Scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,7 @@ Scene.prototype.updateDerivedCommands = function (command) {
const needsLogDepthDerivedCommands =
useLogDepth && !hasLogDepthDerivedCommands;
const needsHdrCommands = useHdr && !hasHdrCommands;
// TODO: if (!useLogDepth && !useHdr), why do we need derived commands?
// PERFORMANCE_IDEA: if (!useLogDepth && !useHdr), we may be able to save a call to updateDerivedCommands.
const needsDerivedCommands = (!useLogDepth || !useHdr) && !hasDerivedCommands;
command.dirty =
command.dirty ||
Expand Down

0 comments on commit 0350152

Please sign in to comment.