Fix issue with copying to a texture from a HTMLVideoElement #12224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
HTMLVideoElement
has additionalvideoHeight
andvideoWidth
properties. These are the intrinsic dimensions. If we rely on theheight
andwidth
values, we can get sub optimal values, and – as in the case of the reported bug – sometimes0
values, which can break the WebGL operation entirely.While I was in that code, I also opted to use
naturalHeight
andnaturalWidth
forHTMLImageElement
, as those the intrinsic, not scaled, dimensions.Issue number and link
Fixes #12219
Testing plan
Video.html
Sandcastle exampleAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my changeI have updated the inline documentation, and included code examples where relevant