-
Notifications
You must be signed in to change notification settings - Fork 31
Fix NRAAS settings and mod tunings #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OhRudi
wants to merge
3
commits into
Chain-Reaction:master
Choose a base branch
from
OhRudi:update-nraas-settings-and-mod-tunings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix NRAAS settings and mod tunings #32
OhRudi
wants to merge
3
commits into
Chain-Reaction:master
from
OhRudi:update-nraas-settings-and-mod-tunings
+271
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable values here a list of all updates with explenations NRaasConsigner/XML/ConsignerSpacePersistedSettings.xml - added new setting "kReportGate" with default value from the code NRaasDresser/XML/Dresser+DresserSettings.xml - added new setting "kCheckOutfitsOnReset" with default value from the code - all tested with a updated NRaas Mod-Tuning, that manipulates the new setting, see screenshots - updated the default value of "kCheckOutfits" to "True", taken from code - updated some comments with the ones from the code - removed settings "kRotateMartialOutfit", "kAddRandomBodyHair", "kAddRandomMaleMakeup", "kAddRandomFemaleMakeup", cause they're no longer used in code NRaasDresser/XML/Kathy/Dresser+DresserSettings.xml - updated these personal settings to match the changes in the main settings of the Dresser mod NRaasDresser/XML/Personal/Dresser+DresserSettings.xml - updated these personal settings to match the changes in the main settings of the Dresser mod NRaasGoHere/XML/GoHereSpacePersistedSettings.xml - added new settings "kDisallowCarRouting", "kDisallowBoatRouting", "kDisallowMermaidRouting" with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots - added new settings "kServiceSimsIgnoreAllDoorOptions", "kRoleSimsIgnoreAllDoorOptions", "kEnableDoorTooltips" with default values from the code - **BUT I COULDN'T FIND THEM IN GAME, NOR DOKUMENTATION OF THEM ON THE NRAAS SITE, PLEASE HELP** NRaasMasterController/XML/MasterControllerSpacePersistedSettings.xml - added new setting "kMaxCASSliders" with default value from the code - all tested with a updated NRaas Mod-Tuning, that manipulates the new setting, see screenshots - added new setting "kUniGenderAdult" with default value from the code - **I FOUND IT IN GAME, BUT NO DOKUMENTATION OF THIS ON THE NRAAS SITE, PLEASE HELP** - removed setting "kMakeupByCategory", "kTagInfo", "kEnableMemories", "kBodyHairForAll", "kSubtleMapTags", cause they're no longer used in code NRaasOverwatch/XML/OverwatchSpacePersistedSettings.xml - replaced "kBootAllGnomes" with "kResetAllGnomes", as I found it in the code - added new settings "kDeleteAllMagicGnomes", "kCleanupSinged", "kCleanupSkillModifiers", "kCompressFamilyLevel", "kRouteFailTestMinutes", "kCleanupVehiclesHourly", "kDisableFullMoonLighting", with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots - added new setting "CleanupAging", with default value from the code - **BUT IT'S NOT APPLIED IN THE CODE, PLEASE HELP** - added new setting "kMinimumRouteFail", with default value from the code - **BUT I COULDN'T FIND THEM IN GAME, NOR DOKUMENTATION OF THEM ON THE NRAAS SITE, PLEASE HELP** NRaasOverwatch/XML/Personal/OverwatchSpacePersistedSettings.xml - updated these personal settings to match the changes in the main settings of the MasterController mod NRaasPortraitPanel/XML/PortraitPanelSpacePersistedSettings.xml - updated many comments to match those in the code NRaasRegister/XML/RegisterSpacePersistedSettings.xml - added new settings "kTouristChanceOfLeaving", "kTouristAmount", "kPayPerProprietor", "kPayPerConcessionsStandMerchant", "kPayPerKissingBoothAttendant", "kPayPerPotionShopMerchant", "kPayPerUniversityMascot", "kPayPerBaristaBarTender", "kPayPerHobbyShopMerchant", "kPayPerCafeteriaWaiter", "kPayPerBotShopMerchant", "kMaximumPaparazzi", with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots - added new setting "kAllowHomeworldTourists", with default value from the code - **BUT I COULDN'T FIND IT IN GAME, NOR DOKUMENTATION OF THIS ON THE NRAAS SITE, PLEASE HELP** NRaasRelativity/XML/RelativitySpacePersistedSettings.xml - added new settings "kCyclesPerUpdate", "kPerformRelativeTuningAlterations", with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots NRaasTempest/TempestSpace/PersistedSettings.cs - edited the tunable comments, removed a typo and added the fahrenheit unit for clarity NRaasTempest/XML/TempestSpacePersistedSettings.xml - added new settings "kRemoveLeavesInWinter", "kChanceOccultItemTrickOrTreat", "kAutoLightFireplaces", "kAutoLightFireplacesTemperature", with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots NRaasTraveler/XML/TravelerSpacePersistedSettings.xml - added new settings "kDisableDescedants", "kChanceOfOccultHybrid", "kChanceOfOccultMutation", "kMaxOccult", "kDisableDescendantModification", with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots - removed setting "kRemoveTravelRestrictions", cause it's no longer used in code NRaasVector/XML/VectorSpacePersistedSettings.xml - updated some comments with the ones from the code NRaasWoohooerKamaSimtra/XML/WoohooerSpaceSkillsKamaSimtraSettings.xml - added new settings "kDistinctSimStats", "kCyberWoohooBaseChanceScoring", "kSeedServicePool", with default values from the code - all tested with a updated NRaas Mod-Tuning, that manipulates those new settings, see screenshots - updated some comments with the ones from the code NRaasWoohooer/XML/WoohooerTuningCat.xml NRaasWoohooer/XML/WoohooerTuningDog.xml (same here) NRaasWoohooer/XML/WoohooerTuningHorse.xml (same here) - updated the default value for "kMaximumHouseholdSizeForAutonomous" to match the one form the code - all tested with a updated NRaas Mod-Tuning, that manipulates the new setting, see screenshots - removed settings "kLikingGatingForAutonomousRomance", "kTeenTryForBabyAutonomous", cause they're no longer used in code - updated the default value for "kWoohooCountScoreFactor" to match the one form the code - **BUT I COULDN'T FIND IT IN GAME, BUT IT HAS DOKUMENTATION ON THE NRAAS SITE, PLEASE HELP** - for setting "kWoohooBaseChanceScoring" - **I COULDN'T FIND IT IN GAME, BUT IT HAS DOKUMENTATION ON THE NRAAS SITE, PLEASE HELP**
NRaasSaver/XML/SaverOptions.xml - added new settings "kPauseOnLoad", "kPauseOnSave" with default values from the code NRaasSaver/Saver.cs NRaasSaver/SaverSpace/PersistedSettings.cs - moved the tunable settings into one class - this previosly caused the settings in a mod tuning to not apply - see screenshots for the proof
…lRoles/MaximumPaparazzi.cs`
Author
Screenshots
Consigner - Proof that the adjusted Tuning worksDresser - Proof that the adjusted Tuning worksGoHere - Proof that the adjusted Tuning works
MasterController - Proof that the adjusted Tuning worksOverwatch - Proof that the adjusted Tuning worksRegister - Proof that the adjusted Tuning worksRelativity - Proof that the adjusted Tuning worksSaver - Proof that the adjusted Tuning works
Tempest - Proof that the adjusted Tuning worksTraveler - Proof that the adjusted Tuning worksWoohooer Cat - Proof that the adjusted Tuning worksWoohooer Dog - Proof that the adjusted Tuning worksWoohooer Horse - Proof that the adjusted Tuning worksWoohooer Kama Simtra Module - Proof that the adjusted Tuning works |
Author
|
@Chain-Reaction please merge this with the main branch ^^ The Pull-Request is one year old by now ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

@Chain-Reaction
Hello, I updated many of the XML code for the tunable settings of many nraas mods.
There were some differences between the tunable settings in the code and the XML
code that a mod-user can use to set standart settings.
Additionally I found two minor bugs and fixed them as well.
I tested all changes in game and attached screenshots in the comments here on GitHub.
Here's a link to download all the Mod-Tuning files, with updated XML, all tested in game.
Please read through the commit comments thorughly, cause I still found some settings that have
open questions for me. I wrote about them in the commit messages. :)
Thank you & Happy Simming ^^