Chaincash store updates/impl #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-weir
commented
Jan 1, 2024
ross-weir
commented
Jan 2, 2024
ross-weir
force-pushed
the
start-datastore-impl
branch
from
80a10ea to
a877773
Compare
ross-weir
commented
Jan 4, 2024
ross-weir
commented
Jan 4, 2024
ross-weir
commented
Jan 7, 2024
docs/MODEL.md
Outdated
| int id PK | ||
| int note_id FK | ||
| int type "Type enum of the denomination, 0 = gold" |
There was a problem hiding this comment.
would make sense to have a denomination for erg as well? so this is used polymorphically?
ross-weir
commented
Jan 8, 2024
| impl TryFrom<&ErgoBox> for ReserveBoxSpec { | ||
| type Error = Error; | ||
|
|
||
| fn try_from(value: &ErgoBox) -> Result<Self, Self::Error> { |
There was a problem hiding this comment.
should also check the ergo tree to ensure its a reserve box
ross-weir
commented
Jan 8, 2024
| Ok(reg.v.try_extract_into::<EcPoint>().unwrap()) | ||
| } else { | ||
| Err(Error::InvalidType { | ||
| field: "owner".to_owned(), |
There was a problem hiding this comment.
this field could be &'static str typed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.sign_and_submitto return the signed transaction so we have access toErgoBoxes, we need them for box ids