Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gating for slow tests and cache SRS using git LFS #27

Closed
wants to merge 16 commits into from

Conversation

willemolding
Copy link
Collaborator

Test runs were previously using too much time/memory and getting killed by GitHub.

This PR:

  • Adds new cargo features: 'test-full-prover' and 'test-evm-verifier' which must be enabled to test using the full prover and prover+evm verifier respectively. These will not be enabled by default or for CI tests
  • Adds the .srs files to the repo using git LFS. Having these cached speeds up the tests significantly compared with regenerating them each time. LFS ensures this does not bloat the git history but also allows the files to be fetched when needed.

@willemolding
Copy link
Collaborator Author

Possibly this is still being killed for using too much memory.. Error: Process completed with exit code 143.

@nulltea
Copy link
Member

nulltea commented Oct 30, 2023

Thanks for this PR, @willemolding! Let me check if changing the circuit degree will help with memory limit

@nulltea
Copy link
Member

nulltea commented Dec 13, 2023

CI tests now run mock prover with no SRS or prover keys loaded, thus these changes are no longer needed. Thanks anyway :)

@nulltea nulltea closed this Dec 13, 2023
@nulltea nulltea deleted the willem/full-prover-tests-behind-feature branch December 13, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants