feat: remove duplicate/unused metrics from asyncAggregateWithRandomness

ChainSafe · Oct 29, 2024 · 6760bb1 · 6760bb1
1 parent 9bed959
commit 6760bb1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/packages/beacon-node/src/chain/bls/multithread/jobItem.ts b/packages/beacon-node/src/chain/bls/multithread/jobItem.ts
@@ -61,12 +61,9 @@ export async function jobItemWorkReq(job: JobQueueItem, metrics: Metrics | null)
         })),
       };
     case JobQueueItemType.sameMessage: {
-      metrics?.blsThreadPool.aggregateWithRandomnessSets.inc(job.sets.length);
-      const timer = metrics?.blsThreadPool.aggregateWithRandomnessJobTime.startTimer();
       const {pk, sig} = await asyncAggregateWithRandomness(
         job.sets.map((set) => ({pk: set.publicKey, sig: set.signature}))
       );
-      timer?.();
 
       return {
         opts: job.opts,

diff --git a/packages/beacon-node/src/metrics/metrics/lodestar.ts b/packages/beacon-node/src/metrics/metrics/lodestar.ts
@@ -497,15 +497,6 @@ export function createLodestarMetrics(
         name: "lodestar_bls_thread_pool_batchable_sig_sets_total",
         help: "Count of total batchable signature sets",
       }),
-      aggregateWithRandomnessSets: register.gauge({
-        name: "lodestar_bls_thread_pool_aggregate_with_randomness_libuv_sets_total",
-        help: "Number of sets being asyncAggregateWithRandomness on libuv thread",
-      }),
-      aggregateWithRandomnessJobTime: register.histogram({
-        name: "lodestar_bls_thread_pool_aggregate_with_randomness_libuv_job_time_seconds",
-        help: "Total time performing aggregateWithRandomness on libuv thread",
-        buckets: [0.001, 0.005, 0.01, 0.1],
-      }),
       pubkeysAggregationMainThreadDuration: register.histogram({
         name: "lodestar_bls_thread_pool_pubkeys_aggregation_main_thread_time_seconds",
         help: "Total time spent aggregating pubkeys on main thread",