Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: epoch cache error should be treated with care in gossips validation #5939

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix: epoch cache error should be treated with care in gossips validation #5939

merged 2 commits into from
Sep 11, 2023

Conversation

nazarhussain
Copy link
Contributor

Motivation

Make the error logging more user friendly.

Description

Some epoch cache related errors were treated aggressively and rather to be treated more naturally in the gossips with the right error codes.

Closes #5938

Steps to test or reproduce

  • Run all tests.

@nazarhussain nazarhussain requested a review from a team as a code owner September 6, 2023 14:30
@nazarhussain nazarhussain self-assigned this Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: b9f9ebc Previous: bbfdcb4 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 645.17 us/op 635.77 us/op 1.01
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 112.48 us/op 111.62 us/op 1.01
BLS verify - blst-native 1.5282 ms/op 1.5380 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 3.1704 ms/op 3.3140 ms/op 0.96
BLS verifyMultipleSignatures 8 - blst-native 6.7549 ms/op 7.0353 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst-native 25.578 ms/op 25.750 ms/op 0.99
BLS verifyMultipleSignatures 64 - blst-native 54.213 ms/op 49.651 ms/op 1.09
BLS verifyMultipleSignatures 128 - blst-native 103.17 ms/op 97.833 ms/op 1.05
BLS deserializing 10000 signatures 1.0333 s/op 989.92 ms/op 1.04
BLS deserializing 100000 signatures 10.060 s/op 10.055 s/op 1.00
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.4870 ms/op 1.5265 ms/op 0.97
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.6807 ms/op 1.6903 ms/op 0.99
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.7841 ms/op 2.5778 ms/op 1.08
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.2122 ms/op 4.0203 ms/op 1.05
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.6790 ms/op 6.6744 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 31.511 us/op 29.611 us/op 1.06
BLS aggregatePubkeys 128 - blst-native 121.88 us/op 119.86 us/op 1.02
getAttestationsForBlock 54.810 ms/op 45.540 ms/op 1.20
isKnown best case - 1 super set check 586.00 ns/op 416.00 ns/op 1.41
isKnown normal case - 2 super set checks 693.00 ns/op 379.00 ns/op 1.83
isKnown worse case - 16 super set checks 643.00 ns/op 372.00 ns/op 1.73
CheckpointStateCache - add get delete 7.4520 us/op 6.7190 us/op 1.11
validate api signedAggregateAndProof - struct 3.5538 ms/op 3.4314 ms/op 1.04
validate gossip signedAggregateAndProof - struct 3.7704 ms/op 3.2022 ms/op 1.18
validate gossip attestation - vc 640000 1.6178 ms/op 1.6327 ms/op 0.99
batch validate gossip attestation - vc 640000 - chunk 32 195.77 us/op 212.38 us/op 0.92
batch validate gossip attestation - vc 640000 - chunk 64 166.64 us/op 199.93 us/op 0.83
batch validate gossip attestation - vc 640000 - chunk 128 157.33 us/op 190.40 us/op 0.83
batch validate gossip attestation - vc 640000 - chunk 256 145.11 us/op 185.32 us/op 0.78
pickEth1Vote - no votes 1.3540 ms/op 1.7108 ms/op 0.79
pickEth1Vote - max votes 10.411 ms/op 14.358 ms/op 0.73
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.886 ms/op 24.902 ms/op 0.72
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.035 ms/op 38.623 ms/op 0.62
pickEth1Vote - Eth1Data fastSerialize value x2048 661.39 us/op 813.75 us/op 0.81
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.5159 ms/op 6.8018 ms/op 0.81
bytes32 toHexString 539.00 ns/op 690.00 ns/op 0.78
bytes32 Buffer.toString(hex) 322.00 ns/op 358.00 ns/op 0.90
bytes32 Buffer.toString(hex) from Uint8Array 500.00 ns/op 601.00 ns/op 0.83
bytes32 Buffer.toString(hex) + 0x 313.00 ns/op 366.00 ns/op 0.86
Object access 1 prop 0.17100 ns/op 0.21000 ns/op 0.81
Map access 1 prop 0.16900 ns/op 0.18300 ns/op 0.92
Object get x1000 8.4440 ns/op 10.119 ns/op 0.83
Map get x1000 0.67100 ns/op 0.84600 ns/op 0.79
Object set x1000 53.556 ns/op 74.548 ns/op 0.72
Map set x1000 41.891 ns/op 56.017 ns/op 0.75
Return object 10000 times 0.25110 ns/op 0.33160 ns/op 0.76
Throw Error 10000 times 4.1800 us/op 5.2049 us/op 0.80
fastMsgIdFn sha256 / 200 bytes 3.6740 us/op 4.2870 us/op 0.86
fastMsgIdFn h32 xxhash / 200 bytes 310.00 ns/op 391.00 ns/op 0.79
fastMsgIdFn h64 xxhash / 200 bytes 380.00 ns/op 475.00 ns/op 0.80
fastMsgIdFn sha256 / 1000 bytes 12.344 us/op 17.407 us/op 0.71
fastMsgIdFn h32 xxhash / 1000 bytes 433.00 ns/op 619.00 ns/op 0.70
fastMsgIdFn h64 xxhash / 1000 bytes 454.00 ns/op 533.00 ns/op 0.85
fastMsgIdFn sha256 / 10000 bytes 112.16 us/op 138.12 us/op 0.81
fastMsgIdFn h32 xxhash / 10000 bytes 2.0400 us/op 2.7020 us/op 0.75
fastMsgIdFn h64 xxhash / 10000 bytes 1.4380 us/op 1.8560 us/op 0.77
enrSubnets - fastDeserialize 64 bits 1.4110 us/op 1.7390 us/op 0.81
enrSubnets - ssz BitVector 64 bits 483.00 ns/op 606.00 ns/op 0.80
enrSubnets - fastDeserialize 4 bits 171.00 ns/op 280.00 ns/op 0.61
enrSubnets - ssz BitVector 4 bits 452.00 ns/op 613.00 ns/op 0.74
prioritizePeers score -10:0 att 32-0.1 sync 2-0 107.93 us/op 169.54 us/op 0.64
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 151.44 us/op 184.01 us/op 0.82
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 198.84 us/op 233.03 us/op 0.85
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 359.88 us/op 401.36 us/op 0.90
prioritizePeers score 0:0 att 64-1 sync 4-1 414.08 us/op 467.66 us/op 0.89
array of 16000 items push then shift 1.8615 us/op 2.1796 us/op 0.85
LinkedList of 16000 items push then shift 9.9940 ns/op 11.894 ns/op 0.84
array of 16000 items push then pop 90.282 ns/op 107.24 ns/op 0.84
LinkedList of 16000 items push then pop 9.5380 ns/op 12.504 ns/op 0.76
array of 24000 items push then shift 2.6915 us/op 3.5206 us/op 0.76
LinkedList of 24000 items push then shift 9.7340 ns/op 11.977 ns/op 0.81
array of 24000 items push then pop 131.31 ns/op 150.13 ns/op 0.87
LinkedList of 24000 items push then pop 9.3200 ns/op 11.995 ns/op 0.78
intersect bitArray bitLen 8 7.0870 ns/op 9.3190 ns/op 0.76
intersect array and set length 8 58.819 ns/op 78.667 ns/op 0.75
intersect bitArray bitLen 128 33.036 ns/op 41.949 ns/op 0.79
intersect array and set length 128 906.44 ns/op 1.0657 us/op 0.85
bitArray.getTrueBitIndexes() bitLen 128 1.7620 us/op 2.4120 us/op 0.73
bitArray.getTrueBitIndexes() bitLen 248 2.9700 us/op 3.9810 us/op 0.75
bitArray.getTrueBitIndexes() bitLen 512 5.7980 us/op 8.3630 us/op 0.69
Buffer.concat 32 items 998.00 ns/op 1.5290 us/op 0.65
Uint8Array.set 32 items 1.8100 us/op 2.7830 us/op 0.65
Set add up to 64 items then delete first 4.5505 us/op 6.1349 us/op 0.74
OrderedSet add up to 64 items then delete first 5.5579 us/op 7.6723 us/op 0.72
Set add up to 64 items then delete last 4.8318 us/op 6.5048 us/op 0.74
OrderedSet add up to 64 items then delete last 6.2828 us/op 8.2817 us/op 0.76
Set add up to 64 items then delete middle 4.9975 us/op 6.1748 us/op 0.81
OrderedSet add up to 64 items then delete middle 7.6933 us/op 10.162 us/op 0.76
Set add up to 128 items then delete first 9.7823 us/op 13.030 us/op 0.75
OrderedSet add up to 128 items then delete first 12.696 us/op 17.294 us/op 0.73
Set add up to 128 items then delete last 10.210 us/op 12.782 us/op 0.80
OrderedSet add up to 128 items then delete last 13.499 us/op 16.684 us/op 0.81
Set add up to 128 items then delete middle 10.189 us/op 13.219 us/op 0.77
OrderedSet add up to 128 items then delete middle 18.421 us/op 23.692 us/op 0.78
Set add up to 256 items then delete first 21.171 us/op 27.193 us/op 0.78
OrderedSet add up to 256 items then delete first 26.925 us/op 35.859 us/op 0.75
Set add up to 256 items then delete last 19.557 us/op 25.258 us/op 0.77
OrderedSet add up to 256 items then delete last 24.902 us/op 33.271 us/op 0.75
Set add up to 256 items then delete middle 19.850 us/op 24.676 us/op 0.80
OrderedSet add up to 256 items then delete middle 48.802 us/op 60.004 us/op 0.81
transfer serialized Status (84 B) 1.9990 us/op 2.6630 us/op 0.75
copy serialized Status (84 B) 1.7040 us/op 2.0760 us/op 0.82
transfer serialized SignedVoluntaryExit (112 B) 1.9510 us/op 2.6040 us/op 0.75
copy serialized SignedVoluntaryExit (112 B) 1.7100 us/op 2.1110 us/op 0.81
transfer serialized ProposerSlashing (416 B) 2.5260 us/op 3.6420 us/op 0.69
copy serialized ProposerSlashing (416 B) 2.2240 us/op 3.1430 us/op 0.71
transfer serialized Attestation (485 B) 2.3150 us/op 3.5700 us/op 0.65
copy serialized Attestation (485 B) 2.2810 us/op 3.1070 us/op 0.73
transfer serialized AttesterSlashing (33232 B) 2.2850 us/op 3.2900 us/op 0.69
copy serialized AttesterSlashing (33232 B) 5.8080 us/op 8.1380 us/op 0.71
transfer serialized Small SignedBeaconBlock (128000 B) 2.8020 us/op 3.4380 us/op 0.82
copy serialized Small SignedBeaconBlock (128000 B) 15.120 us/op 19.651 us/op 0.77
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2450 us/op 3.6920 us/op 0.88
copy serialized Avg SignedBeaconBlock (200000 B) 21.809 us/op 29.837 us/op 0.73
transfer serialized BlobsSidecar (524380 B) 3.0890 us/op 4.2320 us/op 0.73
copy serialized BlobsSidecar (524380 B) 91.045 us/op 102.14 us/op 0.89
transfer serialized Big SignedBeaconBlock (1000000 B) 3.3040 us/op 4.5150 us/op 0.73
copy serialized Big SignedBeaconBlock (1000000 B) 166.79 us/op 186.78 us/op 0.89
pass gossip attestations to forkchoice per slot 3.9920 ms/op 4.9618 ms/op 0.80
forkChoice updateHead vc 100000 bc 64 eq 0 707.27 us/op 881.40 us/op 0.80
forkChoice updateHead vc 600000 bc 64 eq 0 4.4240 ms/op 7.4583 ms/op 0.59
forkChoice updateHead vc 1000000 bc 64 eq 0 7.8659 ms/op 8.9154 ms/op 0.88
forkChoice updateHead vc 600000 bc 320 eq 0 4.5335 ms/op 5.8399 ms/op 0.78
forkChoice updateHead vc 600000 bc 1200 eq 0 4.4963 ms/op 5.3899 ms/op 0.83
forkChoice updateHead vc 600000 bc 7200 eq 0 6.6611 ms/op 7.2035 ms/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 1000 13.525 ms/op 14.948 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 10000 12.920 ms/op 16.054 ms/op 0.80
forkChoice updateHead vc 600000 bc 64 eq 300000 16.677 ms/op 26.653 ms/op 0.63
computeDeltas 500000 validators 300 proto nodes 8.0507 ms/op 8.3699 ms/op 0.96
computeDeltas 500000 validators 1200 proto nodes 6.9748 ms/op 8.9104 ms/op 0.78
computeDeltas 500000 validators 7200 proto nodes 6.6271 ms/op 9.4526 ms/op 0.70
computeDeltas 750000 validators 300 proto nodes 9.9358 ms/op 13.467 ms/op 0.74
computeDeltas 750000 validators 1200 proto nodes 9.7998 ms/op 11.916 ms/op 0.82
computeDeltas 750000 validators 7200 proto nodes 9.7774 ms/op 11.741 ms/op 0.83
computeDeltas 1400000 validators 300 proto nodes 18.239 ms/op 21.638 ms/op 0.84
computeDeltas 1400000 validators 1200 proto nodes 18.630 ms/op 24.002 ms/op 0.78
computeDeltas 1400000 validators 7200 proto nodes 18.600 ms/op 22.153 ms/op 0.84
computeDeltas 2100000 validators 300 proto nodes 27.997 ms/op 31.642 ms/op 0.88
computeDeltas 2100000 validators 1200 proto nodes 27.819 ms/op 31.334 ms/op 0.89
computeDeltas 2100000 validators 7200 proto nodes 28.979 ms/op 31.940 ms/op 0.91
computeProposerBoostScoreFromBalances 500000 validators 3.5648 ms/op 4.2583 ms/op 0.84
computeProposerBoostScoreFromBalances 750000 validators 3.5794 ms/op 4.1020 ms/op 0.87
computeProposerBoostScoreFromBalances 1400000 validators 3.6081 ms/op 4.0950 ms/op 0.88
computeProposerBoostScoreFromBalances 2100000 validators 3.6504 ms/op 4.0608 ms/op 0.90
altair processAttestation - 250000 vs - 7PWei normalcase 3.7910 ms/op 3.4413 ms/op 1.10
altair processAttestation - 250000 vs - 7PWei worstcase 4.4568 ms/op 3.9583 ms/op 1.13
altair processAttestation - setStatus - 1/6 committees join 214.44 us/op 215.51 us/op 1.00
altair processAttestation - setStatus - 1/3 committees join 421.79 us/op 422.69 us/op 1.00
altair processAttestation - setStatus - 1/2 committees join 607.26 us/op 550.09 us/op 1.10
altair processAttestation - setStatus - 2/3 committees join 761.34 us/op 668.33 us/op 1.14
altair processAttestation - setStatus - 4/5 committees join 957.20 us/op 923.99 us/op 1.04
altair processAttestation - setStatus - 100% committees join 1.1348 ms/op 1.0785 ms/op 1.05
altair processBlock - 250000 vs - 7PWei normalcase 8.4653 ms/op 9.8107 ms/op 0.86
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.707 ms/op 36.548 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 44.142 ms/op 42.114 ms/op 1.05
altair processBlock - 250000 vs - 7PWei worstcase hashState 101.92 ms/op 101.26 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei normalcase 2.6491 ms/op 3.0517 ms/op 0.87
phase0 processBlock - 250000 vs - 7PWei worstcase 35.140 ms/op 34.497 ms/op 1.02
altair processEth1Data - 250000 vs - 7PWei normalcase 628.24 us/op 503.62 us/op 1.25
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 13.716 us/op 16.201 us/op 0.85
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 90.963 us/op 59.053 us/op 1.54
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 25.886 us/op 20.533 us/op 1.26
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 12.501 us/op 9.8550 us/op 1.27
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 200.15 us/op 159.76 us/op 1.25
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.2647 ms/op 2.1144 ms/op 0.60
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.2725 ms/op 3.0314 ms/op 0.75
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.2504 ms/op 3.0327 ms/op 0.74
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.5401 ms/op 3.8050 ms/op 1.19
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.6512 ms/op 3.2814 ms/op 0.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.6491 ms/op 5.7240 ms/op 1.16
Tree 40 250000 create 418.42 ms/op 333.48 ms/op 1.25
Tree 40 250000 get(125000) 218.14 ns/op 208.36 ns/op 1.05
Tree 40 250000 set(125000) 1.0890 us/op 964.39 ns/op 1.13
Tree 40 250000 toArray() 24.095 ms/op 18.138 ms/op 1.33
Tree 40 250000 iterate all - toArray() + loop 24.366 ms/op 18.171 ms/op 1.34
Tree 40 250000 iterate all - get(i) 80.465 ms/op 71.889 ms/op 1.12
MutableVector 250000 create 15.459 ms/op 19.347 ms/op 0.80
MutableVector 250000 get(125000) 7.1440 ns/op 7.0140 ns/op 1.02
MutableVector 250000 set(125000) 294.93 ns/op 241.43 ns/op 1.22
MutableVector 250000 toArray() 3.9233 ms/op 3.1653 ms/op 1.24
MutableVector 250000 iterate all - toArray() + loop 4.1873 ms/op 3.1060 ms/op 1.35
MutableVector 250000 iterate all - get(i) 1.6638 ms/op 1.6244 ms/op 1.02
Array 250000 create 4.1096 ms/op 2.7239 ms/op 1.51
Array 250000 clone - spread 1.1994 ms/op 1.0069 ms/op 1.19
Array 250000 get(125000) 0.56600 ns/op 0.51700 ns/op 1.09
Array 250000 set(125000) 0.63600 ns/op 0.60000 ns/op 1.06
Array 250000 iterate all - loop 86.701 us/op 90.344 us/op 0.96
effectiveBalanceIncrements clone Uint8Array 300000 30.088 us/op 22.767 us/op 1.32
effectiveBalanceIncrements clone MutableVector 300000 325.00 ns/op 284.00 ns/op 1.14
effectiveBalanceIncrements rw all Uint8Array 300000 182.48 us/op 190.51 us/op 0.96
effectiveBalanceIncrements rw all MutableVector 300000 87.978 ms/op 79.290 ms/op 1.11
phase0 afterProcessEpoch - 250000 vs - 7PWei 122.43 ms/op 121.58 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 42.645 ms/op 45.279 ms/op 0.94
altair processEpoch - mainnet_e81889 541.49 ms/op 522.99 ms/op 1.04
mainnet_e81889 - altair beforeProcessEpoch 69.665 ms/op 65.103 ms/op 1.07
mainnet_e81889 - altair processJustificationAndFinalization 17.143 us/op 20.949 us/op 0.82
mainnet_e81889 - altair processInactivityUpdates 9.6542 ms/op 7.0761 ms/op 1.36
mainnet_e81889 - altair processRewardsAndPenalties 66.134 ms/op 82.901 ms/op 0.80
mainnet_e81889 - altair processRegistryUpdates 2.4720 us/op 3.9720 us/op 0.62
mainnet_e81889 - altair processSlashings 601.00 ns/op 770.00 ns/op 0.78
mainnet_e81889 - altair processEth1DataReset 641.00 ns/op 876.00 ns/op 0.73
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3220 ms/op 2.4655 ms/op 0.54
mainnet_e81889 - altair processSlashingsReset 5.0900 us/op 5.6290 us/op 0.90
mainnet_e81889 - altair processRandaoMixesReset 6.5240 us/op 5.7230 us/op 1.14
mainnet_e81889 - altair processHistoricalRootsUpdate 1.1850 us/op 1.1820 us/op 1.00
mainnet_e81889 - altair processParticipationFlagUpdates 2.8150 us/op 2.6080 us/op 1.08
mainnet_e81889 - altair processSyncCommitteeUpdates 833.00 ns/op 676.00 ns/op 1.23
mainnet_e81889 - altair afterProcessEpoch 139.01 ms/op 130.16 ms/op 1.07
capella processEpoch - mainnet_e217614 1.6511 s/op 1.5624 s/op 1.06
mainnet_e217614 - capella beforeProcessEpoch 249.10 ms/op 246.58 ms/op 1.01
mainnet_e217614 - capella processJustificationAndFinalization 14.585 us/op 14.762 us/op 0.99
mainnet_e217614 - capella processInactivityUpdates 21.540 ms/op 21.074 ms/op 1.02
mainnet_e217614 - capella processRewardsAndPenalties 283.19 ms/op 287.53 ms/op 0.98
mainnet_e217614 - capella processRegistryUpdates 28.685 us/op 22.755 us/op 1.26
mainnet_e217614 - capella processSlashings 674.00 ns/op 532.00 ns/op 1.27
mainnet_e217614 - capella processEth1DataReset 818.00 ns/op 472.00 ns/op 1.73
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.3541 ms/op 4.4434 ms/op 0.98
mainnet_e217614 - capella processSlashingsReset 3.5740 us/op 3.2340 us/op 1.11
mainnet_e217614 - capella processRandaoMixesReset 6.3790 us/op 4.6370 us/op 1.38
mainnet_e217614 - capella processHistoricalRootsUpdate 706.00 ns/op 525.00 ns/op 1.34
mainnet_e217614 - capella processParticipationFlagUpdates 3.3880 us/op 2.0720 us/op 1.64
mainnet_e217614 - capella afterProcessEpoch 352.65 ms/op 341.38 ms/op 1.03
phase0 processEpoch - mainnet_e58758 592.53 ms/op 513.14 ms/op 1.15
mainnet_e58758 - phase0 beforeProcessEpoch 137.93 ms/op 129.01 ms/op 1.07
mainnet_e58758 - phase0 processJustificationAndFinalization 24.643 us/op 34.010 us/op 0.72
mainnet_e58758 - phase0 processRewardsAndPenalties 60.203 ms/op 44.414 ms/op 1.36
mainnet_e58758 - phase0 processRegistryUpdates 17.015 us/op 12.069 us/op 1.41
mainnet_e58758 - phase0 processSlashings 1.3840 us/op 583.00 ns/op 2.37
mainnet_e58758 - phase0 processEth1DataReset 881.00 ns/op 490.00 ns/op 1.80
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2787 ms/op 1.3309 ms/op 0.96
mainnet_e58758 - phase0 processSlashingsReset 4.2720 us/op 3.0920 us/op 1.38
mainnet_e58758 - phase0 processRandaoMixesReset 10.724 us/op 6.8830 us/op 1.56
mainnet_e58758 - phase0 processHistoricalRootsUpdate 699.00 ns/op 648.00 ns/op 1.08
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.3420 us/op 4.0660 us/op 1.56
mainnet_e58758 - phase0 afterProcessEpoch 113.34 ms/op 118.63 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.4822 ms/op 1.6951 ms/op 0.87
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6620 ms/op 2.6600 ms/op 0.62
altair processInactivityUpdates - 250000 normalcase 23.185 ms/op 26.363 ms/op 0.88
altair processInactivityUpdates - 250000 worstcase 23.114 ms/op 26.556 ms/op 0.87
phase0 processRegistryUpdates - 250000 normalcase 10.734 us/op 9.8000 us/op 1.10
phase0 processRegistryUpdates - 250000 badcase_full_deposits 429.54 us/op 455.48 us/op 0.94
phase0 processRegistryUpdates - 250000 worstcase 0.5 159.08 ms/op 144.78 ms/op 1.10
altair processRewardsAndPenalties - 250000 normalcase 46.682 ms/op 69.413 ms/op 0.67
altair processRewardsAndPenalties - 250000 worstcase 43.329 ms/op 73.708 ms/op 0.59
phase0 getAttestationDeltas - 250000 normalcase 9.6931 ms/op 8.5692 ms/op 1.13
phase0 getAttestationDeltas - 250000 worstcase 10.135 ms/op 9.0333 ms/op 1.12
phase0 processSlashings - 250000 worstcase 2.6504 ms/op 2.9196 ms/op 0.91
altair processSyncCommitteeUpdates - 250000 167.64 ms/op 188.22 ms/op 0.89
BeaconState.hashTreeRoot - No change 348.00 ns/op 380.00 ns/op 0.92
BeaconState.hashTreeRoot - 1 full validator 163.53 us/op 154.06 us/op 1.06
BeaconState.hashTreeRoot - 32 full validator 1.9791 ms/op 1.6521 ms/op 1.20
BeaconState.hashTreeRoot - 512 full validator 18.356 ms/op 15.313 ms/op 1.20
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 196.05 us/op 168.42 us/op 1.16
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.6147 ms/op 2.3839 ms/op 1.10
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 33.504 ms/op 29.996 ms/op 1.12
BeaconState.hashTreeRoot - 1 balances 159.49 us/op 144.50 us/op 1.10
BeaconState.hashTreeRoot - 32 balances 1.4688 ms/op 1.2805 ms/op 1.15
BeaconState.hashTreeRoot - 512 balances 11.952 ms/op 11.872 ms/op 1.01
BeaconState.hashTreeRoot - 250000 balances 190.83 ms/op 242.42 ms/op 0.79
aggregationBits - 2048 els - zipIndexesInBitList 17.688 us/op 17.458 us/op 1.01
regular array get 100000 times 45.111 us/op 49.528 us/op 0.91
wrappedArray get 100000 times 46.303 us/op 38.479 us/op 1.20
arrayWithProxy get 100000 times 16.839 ms/op 16.768 ms/op 1.00
ssz.Root.equals 277.00 ns/op 253.00 ns/op 1.09
byteArrayEquals 274.00 ns/op 250.00 ns/op 1.10
shuffle list - 16384 els 7.5123 ms/op 8.2055 ms/op 0.92
shuffle list - 250000 els 115.98 ms/op 119.01 ms/op 0.97
processSlot - 1 slots 21.089 us/op 18.847 us/op 1.12
processSlot - 32 slots 3.5886 ms/op 3.4860 ms/op 1.03
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 50.194 ms/op 59.443 ms/op 0.84
getCommitteeAssignments - req 1 vs - 250000 vc 2.5924 ms/op 2.7239 ms/op 0.95
getCommitteeAssignments - req 100 vs - 250000 vc 3.8476 ms/op 3.9196 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1723 ms/op 4.3856 ms/op 0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.9200 ns/op 5.0000 ns/op 0.98
state getBlockRootAtSlot - 250000 vs - 7PWei 989.65 ns/op 908.04 ns/op 1.09
computeProposers - vc 250000 9.8866 ms/op 9.7793 ms/op 1.01
computeEpochShuffling - vc 250000 110.89 ms/op 108.68 ms/op 1.02
getNextSyncCommittee - vc 250000 162.19 ms/op 156.06 ms/op 1.04
computeSigningRoot for AttestationData 28.388 us/op 28.315 us/op 1.00
hash AttestationData serialized data then Buffer.toString(base64) 2.4335 us/op 2.4231 us/op 1.00
toHexString serialized data 1.1983 us/op 1.1353 us/op 1.06
Buffer.toString(base64) 222.65 ns/op 229.45 ns/op 0.97

by benchmarkbot/action

wemeetagain
wemeetagain previously approved these changes Sep 6, 2023
View reviewed changes
@wemeetagain wemeetagain merged commit 80c001b into unstable Sep 11, 2023
11 checks passed
@wemeetagain wemeetagain deleted the nh/5938-epoch-cache-errors branch September 11, 2023 18:17
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epoch cache error should be treated with care in gossips validation
2 participants
@nazarhussain @wemeetagain