Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: n historical states #6008
feat: n historical states #6008
Changes from 23 commits
8c25f9f
763ebde
e3d1bee
6df1b5a
e7bcece
a39cc5f
7214e9d
2b9c491
253811d
2390594
a48f8f6
c5dffed
c4090eb
87cca20
4302ecd
6c1c720
7d5e4f6
de65f2c
aaaa88a
801d521
b206639
ee2e55a
6fdae10
6beaf19
fe0883b
843b824
166ee37
96dba21
f116b93
f624126
0b15ae2
ea56579
dad4483
64e8a4c
63b156c
99d6af5
4669871
d4443ab
0da184d
76d6f99
22cf38c
6e16d94
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log context is different from the one below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider logging slot here (same as above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this inside
if (block.message.slot % SLOTS_PER_EPOCH === 0) {
condition below, otherwise will get "Block error slot=452161 error=Checkpoint state slot must be first in an epoch" error as monitored on test branch