-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto use produceBlockV3 deneb+ unless specified #6262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
previously approved these changes
Jan 8, 2024
nflaig
reviewed
Jan 8, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6262 +/- ##
=========================================
Coverage 80.38% 80.38%
=========================================
Files 202 202
Lines 19622 19622
Branches 1176 1176
=========================================
Hits 15773 15773
Misses 3821 3821
Partials 28 28 |
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
force-pushed
the
produceblockv3-postdeneb
branch
from
January 9, 2024 08:15
94792f8
to
e8b7e9c
Compare
g11tech
changed the title
feat: always use produceBlockV3 post deneb
feat: auto use produceBlockV3 deneb+ unless specified
Jan 9, 2024
nflaig
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in v1.14.0 🎉 |
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
* feat: always use produceBlockV3 post deneb * lint * auto enable only if explicity not provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
produceblockv3 is what is supposed to be used post deneb desipe our prodduceblockv2 and priduceblindedblockv2 being forward compatible with the deneb . this PR puts the deneb proposals on produceblockb3