-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix block production step time panels #6271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6271 +/- ##
============================================
+ Coverage 80.38% 80.47% +0.08%
============================================
Files 202 202
Lines 19622 19622
Branches 1176 1176
============================================
+ Hits 15773 15790 +17
+ Misses 3821 3805 -16
+ Partials 28 27 -1 |
nazarhussain
approved these changes
Jan 9, 2024
🎉 This PR is included in v1.14.0 🎉 |
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed on discord, the panels added in #6145 are not correct as
_sum
and_count
suffixes are missing in the expressions. The dashboard was also not updated according to Contributing to Grafana dashboards which causes a diff locally when runningnode scripts/download_dashboards.mjs
.Description
Fix expressions in block production step time panels, add
_sum
and_count
suffix to each metric name to properly calculate avg time per step.A single expression per label is kept as it is desired to have the labels / graph in a specific order instead of alphabetical order.
Note: A lot of the diff in this PR is due to downloading the dashboard through the API via download script instead of manually applying changing as it was done in #6145.