-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add clone option to state caches #6512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6512 +/- ##
============================================
- Coverage 61.55% 61.54% -0.01%
============================================
Files 556 556
Lines 58586 58629 +43
Branches 1847 1847
============================================
+ Hits 36060 36083 +23
- Misses 22486 22506 +20
Partials 40 40 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
g11tech
approved these changes
Mar 6, 2024
philknows
pushed a commit
that referenced
this pull request
Mar 6, 2024
* feat: clone option for state caches * fix: compilation error
🎉 This PR is included in v1.17.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
StateCloneOpts
for state transition, now we also clone states from state caches so need to add option there alsoDescription
StateCloneOpts
to state caches add apiStateCloneOpts
, it's already done in the current source code for state transition, need to use same params for state cachesget
apiCloses #6511
Test result
Metrics look same to v1.16 after ~3h of testing